You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 03:28:00 UTC
[GitHub] [arrow] wjones127 opened a new pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
wjones127 opened a new pull request #9288:
URL: https://github.com/apache/arrow/pull/9288
These methods are intended to make it easier to work with and debug the Gandiva expression builder.
```python
import pyarrow
import pyarrow.gandiva as gandiva
builder = gandiva.TreeExprBuilder()
lit = builder.make_literal(1000.0, pyarrow.float64())
print(lit)
# Before: <pyarrow.gandiva.Node object at 0x7f36fd37ecf0>
# After: (const double) 1000 raw(408f400000000000)
field = builder.make_field(pyarrow.field('a', pyarrow.float64()))
print(field)
# Before: <pyarrow.gandiva.Node object at 0x7ff7daf99f90>
# After: (double) a
print(builder.make_function('greater_than', [field, lit], pyarrow.bool_()))
# Before: <pyarrow.gandiva.Node object at 0x7ff7d24bde70>
# After: bool greater_than((double) a, (const double) 1000 raw(408f400000000000))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9288:
URL: https://github.com/apache/arrow/pull/9288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9288:
URL: https://github.com/apache/arrow/pull/9288#issuecomment-765095930
https://issues.apache.org/jira/browse/ARROW-11342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
Posted by GitBox <gi...@apache.org>.
wjones127 commented on pull request #9288:
URL: https://github.com/apache/arrow/pull/9288#issuecomment-808988084
> @wjones127 sorry for the late review. This looks OK to me, did you want to add specific tests asserting equality to strings?
Yup that makes sense. I will add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9288:
URL: https://github.com/apache/arrow/pull/9288#issuecomment-765095930
https://issues.apache.org/jira/browse/ARROW-11342
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9288:
URL: https://github.com/apache/arrow/pull/9288#issuecomment-867005845
@wjones127 Really sorry for the delay :-/. I rebased on git master and will merge if CI is green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9288: ARROW-11342: [Python] [Gandiva] Expose ToString and result type information
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9288:
URL: https://github.com/apache/arrow/pull/9288#issuecomment-808769749
@wjones127 sorry for the late review. This looks OK to me, did you want to add specific tests asserting equality to strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org