[GitHub] [lucene] yixunx commented on pull request #756: LUCENE-10470: [Tessellator] Prevent bridges that introduce collinear edges

[GitBox <gi...@apache.org>]

yixunx commented on PR #756:
URL: https://github.com/apache/lucene/pull/756#issuecomment-1088053353

   @iverase As mentioned in my [latest comment on Jira](https://issues.apache.org/jira/browse/LUCENE-10470?focusedCommentId=17517128&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17517128), I found a shape that fails after the latest fix because the final edges still have an area. I was able to get that shape to work by re-introducing your `checkNonCollinearLines` fix, but doing that made `testComplexPolygon47` fail again. I created a [branch](https://github.com/iverase/lucene/compare/LUCENE-10470...yixunx:yixunx/LUCENE-10470?expand=1) with the repro if you want to take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org