[GitHub] [tvm] Mousius commented on a diff in pull request #12663: Always install into a python venv in ci containers

[GitBox <gi...@apache.org>]

Mousius commented on code in PR #12663:
URL: https://github.com/apache/tvm/pull/12663#discussion_r967209623


##########
docker/install/ubuntu_install_python.sh:
##########
@@ -18,28 +18,77 @@
 
 set -e
 set -u
-# Used for debugging RVM build
-set -x
 set -o pipefail
 
-# install python and pip, don't modify this, modify install_python_package.sh
+set -x
+
+if [ -z "${TVM_VENV+x}" ]; then
+    echo "ERROR: expect TVM_VENV env var to be set"
+    exit 2
+fi
+
 apt-get update
-apt-install-and-clear -y python-dev
 
-# python 3.6
+# Ensure lsb-release is installed.
+apt-install-and-clear -y \
+    lsb-core
+
+release=$(lsb_release -sc)
+if [ "${release}" == "bionic" ]; then

Review Comment:
   When I was migrating teams off of conda I used [pyenv](https://github.com/pyenv/pyenv) which would compose into our system with Poetry?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org