[jira] [Comment Edited] (AURORA-1871) Client should reject tasks with duplicate process names

["Pradyumna Kaushik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940560#comment-15940560 ] 

Pradyumna Kaushik edited comment on AURORA-1871 at 3/24/17 3:39 PM:
--------------------------------------------------------------------

1. As pistachio is the one that's parsing the DSL, we would need to change pistachio (which doesn't seem the right thing to do) in order to detect multiple tasks having the same process name.
2. The other solution to this would be to write a parser for the DSL whose sole purpose is to detect flaws in the configuration.

[~joshua.cohen]] what do you think about this?


was (Author: pradyumnakaushik):
1. As pistachio is the one that's parsing the DSL, we would need to change pistachio (which doesn't seem the right thing to do) in order to detect multiple tasks having the same process name.
2. The other solution to this would be to write a parser for the DSL whose sole purpose is to detect flaws in the configuration.

[~jcohen] what do you think about this?

> Client should reject tasks with duplicate process names
> -------------------------------------------------------
>
>                 Key: AURORA-1871
>                 URL: https://issues.apache.org/jira/browse/AURORA-1871
>             Project: Aurora
>          Issue Type: Task
>          Components: Client
>            Reporter: Joshua Cohen
>
> If a user creates a job that contains tasks with the same process name, that info is happily passed on to thermos, which will happily run one of those processes, but maybe display a separate one in the UI. In general the behavior in this case is non-deterministic and can lead to hard to track down bugs.
> We should just short circuit and fail in the client if we detect multiple processes with the same name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)