You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by liming01 <gi...@git.apache.org> on 2016/06/28 09:29:01 UTC
[GitHub] incubator-hawq pull request #757: HAWQ-877. Need to stop building when build...
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/757
HAWQ-877. Need to stop building when building error occurs in gpfdist
Hi @paul-guo- @xunzhang ,
could you please help me to review it. Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liming01/incubator-hawq mli/bld_no_stop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/757.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #757
----
commit 44b0ef7ef81e2dd93231e4aef439236627d17e1e
Author: Ming LI <ml...@pivotal.io>
Date: 2016-06-28T09:25:49Z
HAWQ-877. Need to stop building when building error occurs in gpfdist directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #757: HAWQ-877. Need to stop building when build...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/757
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #757: HAWQ-877. Need to stop building when building err...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/757
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #757: HAWQ-877. Need to stop building when build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68732512
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
+ if [[ $$? -ne 0 ]]; then exit 1; fi \
done
# link
$(CC) $(CFLAGS) -o $(code_dir)gpfdist $(OBJS) $(LIBS)
+ if [[ $$? -ne 0 ]]; then exit 1; fi
--- End diff --
This line code change is not necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #757: HAWQ-877. Need to stop building when build...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68725485
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
+ if [[ $$? -ne 0 ]]; then exit 1; fi \
--- End diff --
indent?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #757: HAWQ-877. Need to stop building when building err...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/757
You can mock a test, e.g. temporarily rename a source file in $(GPFDISTFILES) so that cc fails to compile that file only.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #757: HAWQ-877. Need to stop building when build...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68733952
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
--- End diff --
Get it. But I have no test env for retest this write, I will keep it unchanged because the previous writing was already verified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #757: HAWQ-877. Need to stop building when building err...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/757
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #757: HAWQ-877. Need to stop building when build...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/757#discussion_r68732483
--- Diff: src/bin/gpfdist/Makefile ---
@@ -60,9 +60,11 @@ mkgpfdist: mkdir
for file in $(GPFDISTFILES); do \
( $(CC) $(INCLUDES) $(CFLAGS) $(LIBS) -c $(code_dir)$${file}); \
--- End diff --
Following way is cleaner.
$cmd || exit 1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---