You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/05/04 21:10:04 UTC
Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
Repository: mesos
Description
-------
Added unresolved critical issues to the 1.6 CHANGELOG.
Diffs
-----
CHANGELOG 03675609c6af1c706dd4dae9e9fff3d7e3889568
Diff: https://reviews.apache.org/r/66969/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
Posted by Greg Mann <gr...@mesosphere.io>.
> On May 4, 2018, 10:46 p.m., Chun-Hung Hsiao wrote:
> > CHANGELOG
> > Lines 62 (patched)
> > <https://reviews.apache.org/r/66969/diff/3/?file=2017075#file2017075line62>
> >
> > Did you sort it in the reversed order? ;)
Whoops, thanks Chun-Hung :)
I fixed this with another commit.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/#review202498
-----------------------------------------------------------
On May 4, 2018, 10:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66969/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:34 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unresolved critical issues to the 1.6 CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 02c7d6f82e0bb24c23143f696f29c57076456fa0
>
>
> Diff: https://reviews.apache.org/r/66969/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/#review202498
-----------------------------------------------------------
Fix it, then Ship it!
CHANGELOG
Lines 62 (patched)
<https://reviews.apache.org/r/66969/#comment284309>
Did you sort it in the reversed order? ;)
- Chun-Hung Hsiao
On May 4, 2018, 10:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66969/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:34 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unresolved critical issues to the 1.6 CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 02c7d6f82e0bb24c23143f696f29c57076456fa0
>
>
> Diff: https://reviews.apache.org/r/66969/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/#review202512
-----------------------------------------------------------
PASS: Mesos patch 66969 was successfully built and tested.
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66969
- Mesos Reviewbot Windows
On May 4, 2018, 10:34 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66969/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 10:34 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unresolved critical issues to the 1.6 CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 02c7d6f82e0bb24c23143f696f29c57076456fa0
>
>
> Diff: https://reviews.apache.org/r/66969/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/
-----------------------------------------------------------
(Updated May 4, 2018, 10:34 p.m.)
Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
Added unresolved critical issues to the 1.6 CHANGELOG.
Diffs (updated)
-----
CHANGELOG 02c7d6f82e0bb24c23143f696f29c57076456fa0
Diff: https://reviews.apache.org/r/66969/diff/3/
Changes: https://reviews.apache.org/r/66969/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/#review202491
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66965.
Failed command: `python.exe .\support\apply-reviews.py -n -r 66965`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66969
Relevant logs:
- [apply-review-66965-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66969/logs/apply-review-66965-stdout.log):
```
error: patch failed: CHANGELOG:29
error: CHANGELOG: patch does not apply
```
- Mesos Reviewbot Windows
On May 4, 2018, 9:13 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66969/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 9:13 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unresolved critical issues to the 1.6 CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 03675609c6af1c706dd4dae9e9fff3d7e3889568
>
>
> Diff: https://reviews.apache.org/r/66969/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 66969: Added unresolved critical issues to the 1.6
CHANGELOG.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66969/
-----------------------------------------------------------
(Updated May 4, 2018, 9:13 p.m.)
Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Vinod Kone.
Repository: mesos
Description
-------
Added unresolved critical issues to the 1.6 CHANGELOG.
Diffs (updated)
-----
CHANGELOG 03675609c6af1c706dd4dae9e9fff3d7e3889568
Diff: https://reviews.apache.org/r/66969/diff/2/
Changes: https://reviews.apache.org/r/66969/diff/1-2/
Testing
-------
Thanks,
Greg Mann