[jira] [Updated] (SPARK-46893) Remove inline scripts from UI descriptions

["Willi Raschkowski (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-46893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Willi Raschkowski updated SPARK-46893:
--------------------------------------
    Summary: Remove inline scripts from UI descriptions  (was: Sanitize UI descriptions from inline scripts)

> Remove inline scripts from UI descriptions
> ------------------------------------------
>
>                 Key: SPARK-46893
>                 URL: https://issues.apache.org/jira/browse/SPARK-46893
>             Project: Spark
>          Issue Type: Bug
>          Components: UI, Web UI
>    Affects Versions: 3.4.1
>            Reporter: Willi Raschkowski
>            Priority: Major
>         Attachments: Screen Recording 2024-01-28 at 17.51.47.mov
>
>
> Users can inject inline scripts (e.g. {{onclick}} or {{onmouseover}} handlers) in the UI job and stage descriptions.
> The UI already has precaution to treat, e.g., {{<script>}} tags as plain-text. But that doesn't extend to inline scripts.
> {code:title=Bad job descriptions}
> scala> sc.setJobDescription("""<a href="/link" onmouseover="alert('oops');">onmouseover</a>""")
> scala> spark.sql("SELECT 1").show()
> ...
> scala> sc.setJobDescription("""<a href="/link" onclick="alert('oops');">onclick</a>""")
> scala> spark.sql("SELECT 1").show()
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org