[GitHub] [incubator-pekko-persistence-cassandra] mdedetrich commented on a diff in pull request #46: Apply compat changes from latest Pekko

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #46:
URL: https://github.com/apache/incubator-pekko-persistence-cassandra/pull/46#discussion_r1189765346


##########
core/src/main/scala/org/apache/pekko/persistence/cassandra/query/EventsByPersistenceIdStage.scala:
##########
@@ -16,16 +16,16 @@ package org.apache.pekko.persistence.cassandra.query
 import com.datastax.oss.driver.api.core.CqlSession
 import com.datastax.oss.driver.api.core.cql._
 import org.apache.pekko
-import pekko.Done
-import pekko.annotation.InternalApi
-import pekko.persistence.cassandra.PluginSettings
-import pekko.stream.stage._
-import pekko.stream.{ Attributes, Outlet, SourceShape }
+import org.apache.pekko.Done

Review Comment:
    Can we keep the `pekko` prefix here rather than using `org.apache.pekko`. While there is an argument to use the FQCN the community needs to decide on this and it will likely be done as part of a scalafix integration.



##########
project/Dependencies.scala:
##########
@@ -17,16 +17,16 @@ object Dependencies {
   val scala3Version = "3.1.2" // not yet enabled - missing pekko-http/pekko-management Scala 3 artifacts
   val scalaVersions = Seq(scala212Version, scala213Version)
 
-  val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26630-2c4d0ee0-SNAPSHOT")
+  val pekkoVersion = System.getProperty("override.pekko.version", "0.0.0+26656-898c6970-SNAPSHOT")
   val pekkoVersionInDocs = "current"
   val cassandraVersionInDocs = "4.0"
   // Should be sync with the version of the driver in Pekko Connectors Cassandra
   val driverVersionInDocs = "4.6"
 
-  val pekkoConnectorsVersion = "0.0.0+64-20da4165-SNAPSHOT"
+  val pekkoConnectorsVersion = "0.0.0+82-5880466e-SNAPSHOT"

Review Comment:
   So I am currently working on pekko-connectors (see https://github.com/apache/incubator-pekko-connectors/pull/101) and there are some blocking upstream changes needed to get it to work.
   
   Due to dependency management hell, it would be ideal to release pekko-connectors once that PR is merged and use that version here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org