[jira] [Commented] (JCLOUDS-1141) Azurecompute - RoleToXML doesn't close the ConfigurationSets element corretly

["Josef Cacek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15381463#comment-15381463 ] 

Josef Cacek commented on JCLOUDS-1141:
--------------------------------------

PR: https://github.com/jclouds/jclouds-labs/pull/303

> Azurecompute - RoleToXML doesn't close the ConfigurationSets element corretly
> -----------------------------------------------------------------------------
>
>                 Key: JCLOUDS-1141
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1141
>             Project: jclouds
>          Issue Type: Bug
>          Components: jclouds-labs
>    Affects Versions: 2.0.0
>            Reporter: Josef Cacek
>            Priority: Critical
>              Labels: azurecompute
>
> There is a missing {{.up()}} call for "ConfigurationSets" element in {{RoleToXML}} class.
> So the generated XML looks like:
> {code:xml}
> <PersistentVMRole xmlns="http://schemas.microsoft.com/windowsazure">
>   <RoleName>...</RoleName>
>   <RoleType>PersistentVMRole</RoleType>
>   <ConfigurationSets>
>     <ConfigurationSet>...</ConfigurationSet>
>     <DataVirtualHardDisks/><OSVirtualHardDisk>...</OSVirtualHardDisk>
>     <RoleSize>Basic_A1</RoleSize>
>   </ConfigurationSets>
> </PersistentVMRole>
> {code}
> The correct output is:
> {code:xml}
> <PersistentVMRole xmlns="http://schemas.microsoft.com/windowsazure">
>   <RoleName>...</RoleName>
>   <RoleType>PersistentVMRole</RoleType>
>   <ConfigurationSets>
>     <ConfigurationSet>...</ConfigurationSet>
>   </ConfigurationSets>
>   <DataVirtualHardDisks/>
>   <OSVirtualHardDisk>...</OSVirtualHardDisk>
>   <RoleSize>Basic_A1</RoleSize>
> </PersistentVMRole>
> {code}
> See https://msdn.microsoft.com/en-us/library/azure/jj157187.aspx 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)