[GitHub] [hadoop] jojochuang commented on a diff in pull request #5252: HADOOP-18584. [NFS GW] IdleStateHandler is not Shareable.

["jojochuang (via GitHub)" <gi...@apache.org>]

jojochuang commented on code in PR #5252:
URL: https://github.com/apache/hadoop/pull/5252#discussion_r1089771999


##########
hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/oncrpc/RpcUtil.java:
##########
@@ -170,15 +172,18 @@ public void channelRead(ChannelHandlerContext ctx, Object msg)
    */
   @ChannelHandler.Sharable
   private static final class RpcUdpResponseStage extends
-      ChannelInboundHandlerAdapter {
+          SimpleChannelInboundHandler<RpcResponse> {
+    public RpcUdpResponseStage() {
+      // do not auto release the RpcResponse message.

Review Comment:
   no... i checked with io.netty.leakDetection.level=PARANOID, and it would actually throw an exception because the refcount would go negative.
   The response is released. Looks like IdleStateHandler releases the object for us.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org