You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by "Keith Wall (Created) (JIRA)" <ji...@apache.org> on 2012/02/07 16:16:59 UTC

[jira] [Created] (QPID-3820) ProducerFlowControlTest test fails sprodically on 0-10 profiles

ProducerFlowControlTest test fails sprodically on 0-10 profiles
---------------------------------------------------------------

                 Key: QPID-3820
                 URL: https://issues.apache.org/jira/browse/QPID-3820
             Project: Qpid
          Issue Type: Bug
          Components: Java Broker, Java Tests
            Reporter: Keith Wall


On the 0-10 profiles, we see ProducerFlowControlTest#testSendTimeout occasionally fail with the following stack trace:


{code}
org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout
Failing for the past 1 build (Since Failed#47 )
Took 10 sec.
Error Message

No timeout exception on sending

Stacktrace

junit.framework.AssertionFailedError: No timeout exception on sending
	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:344)
	at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
	at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)

{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

[jira] [Updated] (QPID-3820) ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/QPID-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Keith Wall updated QPID-3820:
-----------------------------

    Status: Ready To Review  (was: In Progress)
    
> ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3820
>                 URL: https://issues.apache.org/jira/browse/QPID-3820
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Tests
>    Affects Versions: 0.15
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>
> On the 0-10 profiles, we see ProducerFlowControlTest#testSendTimeout occasionally fail with the following stack trace:
> {code}
> org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout
> Failing for the past 1 build (Since Failed#47 )
> Took 10 sec.
> Error Message
> No timeout exception on sending
> Stacktrace
> junit.framework.AssertionFailedError: No timeout exception on sending
> 	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:344)
> 	at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
> 	at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

[jira] [Resolved] (QPID-3820) ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/QPID-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-3820.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.15

Looks good to me.
                
> ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3820
>                 URL: https://issues.apache.org/jira/browse/QPID-3820
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Tests
>    Affects Versions: 0.15
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>             Fix For: 0.15
>
>
> On the 0-10 profiles, we see ProducerFlowControlTest#testSendTimeout occasionally fail with the following stack trace:
> {code}
> org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout
> Failing for the past 1 build (Since Failed#47 )
> Took 10 sec.
> Error Message
> No timeout exception on sending
> Stacktrace
> junit.framework.AssertionFailedError: No timeout exception on sending
> 	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:344)
> 	at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
> 	at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

[jira] [Issue Comment Edited] (QPID-3820) ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

Posted by "Keith Wall (Issue Comment Edited) (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/QPID-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202839#comment-13202839 ] 

Keith Wall edited comment on QPID-3820 at 2/7/12 9:52 PM:
----------------------------------------------------------

Whilst I have not been able to successfully reproduce the testSendTimeout issue reported above, I can say that the whole test suite looks very brittle:  it relies heavily on Thread.sleep() in the hope that sufficient time will have passed to allow observations to be made (exception to arrive etc, messages delivery to be stopped) etc.   The Thread.sleep() approach also means the testcase is very slow 120s..160s on my box.  I've seen a couple of other PSFC tests fail during the course of the last few hours.  It would be best if this suite were rewritten.








                
      was (Author: k-wall):
    Whilst I have not been able to successfully reproduce the testSendTimeout issue report above, I can say that the whole test suite looks very brittle:  it relies heavily on Thread.sleep() in the hope that sufficient time will have passed to allow an observation to be made (exception to arrive etc, messages delivery to be stopped) etc.   The Thread.sleep() approach also means the testcase is very slow 120s..160s on my box.  I've seen a couple of other PSFC tests fail during the course of the last few hours.  It would be best if this suite were rewritten.








                  
> ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3820
>                 URL: https://issues.apache.org/jira/browse/QPID-3820
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Tests
>    Affects Versions: 0.15
>            Reporter: Keith Wall
>
> On the 0-10 profiles, we see ProducerFlowControlTest#testSendTimeout occasionally fail with the following stack trace:
> {code}
> org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout
> Failing for the past 1 build (Since Failed#47 )
> Took 10 sec.
> Error Message
> No timeout exception on sending
> Stacktrace
> junit.framework.AssertionFailedError: No timeout exception on sending
> 	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:344)
> 	at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
> 	at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

[jira] [Commented] (QPID-3820) ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles

Posted by "Keith Wall (Commented) (JIRA)" <ji...@apache.org>.

    [ https://issues.apache.org/jira/browse/QPID-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204617#comment-13204617 ] 

Keith Wall commented on QPID-3820:
----------------------------------

Patch applied to resolve defect in testcase.  Robbie, can you review the change please?
                
> ProducerFlowControlTest#testSendTimeout test fails sprodically on 0-10 profiles
> -------------------------------------------------------------------------------
>
>                 Key: QPID-3820
>                 URL: https://issues.apache.org/jira/browse/QPID-3820
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Tests
>    Affects Versions: 0.15
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>
> On the 0-10 profiles, we see ProducerFlowControlTest#testSendTimeout occasionally fail with the following stack trace:
> {code}
> org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout
> Failing for the past 1 build (Since Failed#47 )
> Took 10 sec.
> Error Message
> No timeout exception on sending
> Stacktrace
> junit.framework.AssertionFailedError: No timeout exception on sending
> 	at org.apache.qpid.server.queue.ProducerFlowControlTest.testSendTimeout(ProducerFlowControlTest.java:344)
> 	at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:237)
> 	at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:138)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org