You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/26 20:31:58 UTC

[GitHub] [ratis] adoroszlai opened a new pull request, #729: RATIS-1691. Potential deadlock in server shutdown

adoroszlai opened a new pull request, #729:
URL: https://github.com/apache/ratis/pull/729

   ## What changes were proposed in this pull request?
   
   Move shutdown of `RaftServerProxy#executor` inside the block which is executed after lifecycle check.  This prevents subsequent callers (notably `StateMachineUpdater`) from blocking until the executor is shutdown.
   
   https://issues.apache.org/jira/browse/RATIS-1691
   
   ## How was this patch tested?
   
   Ran all Ratis unit tests locally.
   
   Ran Ozone integration tests with 2.4.0-rc0 + RATIS-1687 + this change.  Most tests passed (most importantly HA tests that timed out previously).
   
   Regular CI:
   https://github.com/adoroszlai/incubator-ratis/actions/runs/2935727046


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo merged pull request #729: RATIS-1691. Potential deadlock in server shutdown

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #729:
URL: https://github.com/apache/ratis/pull/729


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] adoroszlai commented on pull request #729: RATIS-1691. Potential deadlock in server shutdown

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #729:
URL: https://github.com/apache/ratis/pull/729#issuecomment-1235136179

   Thanks @szetszwo for reviewing and committing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org