You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by bbende <gi...@git.apache.org> on 2018/03/02 15:53:52 UTC
[GitHub] nifi pull request #2505: NIFI-4920 Skipping sensitive properties when updati...
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2505
NIFI-4920 Skipping sensitive properties when updating component prope…
…rties from versioned component
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-4920
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2505.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2505
----
commit 0b23d961ae3ff089f469a1e8768c854d10777ce8
Author: Bryan Bende <bb...@...>
Date: 2018-03-02T15:52:22Z
NIFI-4920 Skipping sensitive properties when updating component properties from versioned component
----
---
[GitHub] nifi issue #2505: NIFI-4920 Skipping sensitive properties when updating comp...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2505
Thanks @bbende! Code looks good. Verified that i was able to recreate issue and that it went away with the patch. +1 merged to master.
---
[GitHub] nifi pull request #2505: NIFI-4920 Skipping sensitive properties when updati...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2505
---
[GitHub] nifi issue #2505: NIFI-4920 Skipping sensitive properties when updating comp...
Posted by jvwing <gi...@git.apache.org>.
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2505
The extra close is a result of my carelessness, sorry. That should have been for PR #2506.
---