You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jsirois <gi...@git.apache.org> on 2016/02/13 21:28:08 UTC
[GitHub] thrift pull request: THRIFT-3622 Fix deprecated uses of std::auto_...
GitHub user jsirois opened a pull request:
https://github.com/apache/thrift/pull/860
THRIFT-3622 Fix deprecated uses of std::auto_ptr
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsirois/thrift THRIFT-3622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #860
----
commit 95a5eefbce34a7c5766c5015fe0fa8b35d647f28
Author: John Sirois <js...@apache.org>
Date: 2016-02-13T20:27:03Z
Replace deprecated auto_ptr uses with unique_ptr.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3622 Fix deprecated uses of std::auto_...
Posted by jsirois <gi...@git.apache.org>.
Github user jsirois commented on the pull request:
https://github.com/apache/thrift/pull/860#issuecomment-184741791
Thanks for taking a look @nsuke, I'm going to abandon this change until I understand the c/c++ build landscape better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3622 Fix deprecated uses of std::auto_...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/860#issuecomment-183872537
It seems that our Autools build does not use -isystem to include boost (i.e. using -I), so I'm afraid that we cannot remove the warnings by using scoped_ptr.
Because last time I checked, scoped_ptr was using auto_ptr inside their code and there was no workaround.
But it would still remove them from CMake build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3622 Fix deprecated uses of std::auto_...
Posted by nsuke <gi...@git.apache.org>.
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/860#issuecomment-183864947
Really unlucky for us that Travis builds aren't invoked for this PR.
We still need C++98 so cannot use `unique_ptr` yet, so we're using `boost::scoped_ptr` in such cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-3622 Fix deprecated uses of std::auto_...
Posted by jsirois <gi...@git.apache.org>.
Github user jsirois closed the pull request at:
https://github.com/apache/thrift/pull/860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---