You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2024/01/30 01:02:47 UTC
[PR] feat(ci): add a check to make sure there's no hold label on the PR [superset]
mistercrunch opened a new pull request, #26877:
URL: https://github.com/apache/superset/pull/26877
noticed on another PR (https://github.com/apache/superset/pull/26836) that we use `hold.*` labels, but they don't really hold the merge. After almost merging and realizing the hold after, I got GPT to generate the action here and tested it on that PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(ci): add a check to make sure there's no hold label on the PR [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #26877:
URL: https://github.com/apache/superset/pull/26877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(ci): add a check to make sure there's no hold label on the PR [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26877:
URL: https://github.com/apache/superset/pull/26877#issuecomment-1921480024
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(ci): add a check to make sure there's no hold label on the PR [superset]
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #26877:
URL: https://github.com/apache/superset/pull/26877#discussion_r1470794829
##########
.github/workflows/no-hold-label.yml:
##########
@@ -0,0 +1,20 @@
+name: Hold Label Check
+
+on:
+ pull_request:
+ types: [labeled, unlabeled, opened, reopened, synchronize]
+
+jobs:
+ check-hold-label:
+ runs-on: ubuntu-latest
+ steps:
+ - name: Check for 'hold' label
+ uses: actions/github-script@v3
+ with:
+ github-token: ${{secrets.GITHUB_TOKEN}}
+ script: |
+ const payload = context.payload.pull_request
+ const label = !!payload.labels.find(label => label.name.includes('hold'))
Review Comment:
nit: `const holdLabelPresent = payload.labels.some(label => label.name.startsWith('hold'));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org