You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/06 04:23:55 UTC
[GitHub] [flink] Tartarus0zm opened a new pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Tartarus0zm opened a new pull request #12508:
URL: https://github.com/apache/flink/pull/12508
## What is the purpose of the change
Add error message to precondition in KeyGroupPartitionedPriorityQueue.
Avoid unclear exception information like
```
java.lang.ArrayIndexOutOfBoundsException: -49
at org.apache.flink.runtime.state.heap.KeyGroupPartitionedPriorityQueue.getKeyGroupSubHeapForElement(KeyGroupPartitionedPriorityQueue.java:174)
at org.apache.flink.runtime.state.heap.KeyGroupPartitionedPriorityQueue.add(KeyGroupPartitionedPriorityQueue.java:110)
at org.apache.flink.streaming.api.operators.InternalTimerServiceImpl.registerProcessingTimeTimer(InternalTimerServiceImpl.java:203)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator$Context.registerProcessingTimeTimer(WindowOperator.java:901)
at org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger.onElement(ProcessingTimeTrigger.java:36)
at org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger.onElement(ProcessingTimeTrigger.java:28)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator$Context.onElement(WindowOperator.java:920)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator.processElement(WindowOperator.java:402)
at org.apache.flink.streaming.runtime.tasks.OneInputStreamTask$StreamTaskNetworkOutput.processRecord(OneInputStreamTask.java:204)
at org.apache.flink.streaming.runtime.tasks.OneInputStreamTask$StreamTaskNetworkOutput.emitRecord(OneInputStreamTask.java:196)
at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.processElement(StreamTaskNetworkInput.java:151)
at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.emitNext(StreamTaskNetworkInput.java:128)
at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:69)
at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:311)
at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:187)
at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:487)
at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:470)
at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:707)
at org.apache.flink.runtime.taskmanager.Task.run(Task.java:532)
at java.lang.Thread.run(Thread.java:745)
```
## Brief change log
no
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639978998
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8953e51d845b3a61608d6e08f9caf462e43775bc (Sat Jun 06 04:26:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639981987
@zentol can you review this for me if you have time, thanks ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-643576762
@carp84 thanks for your review first.
in my case, the user custom a KeySelector and the protobuf object that generate the key use Serializer with `immutable` is true.
I only got the error message like this:
```
java.lang.ArrayIndexOutOfBoundsException: -49
at org.apache.flink.runtime.state.heap.KeyGroupPartitionedPriorityQueue.getKeyGroupSubHeapForElement(KeyGroupPartitionedPriorityQueue.java:174)
at org.apache.flink.runtime.state.heap.KeyGroupPartitionedPriorityQueue.add(KeyGroupPartitionedPriorityQueue.java:110)
at org.apache.flink.streaming.api.operators.InternalTimerServiceImpl.registerProcessingTimeTimer(InternalTimerServiceImpl.java:203)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator$Context.registerProcessingTimeTimer(WindowOperator.java:901)
at org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger.onElement(ProcessingTimeTrigger.java:36)
at org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger.onElement(ProcessingTimeTrigger.java:28)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator$Context.onElement(WindowOperator.java:920)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator.processElement(WindowOperator.java:402)
at org.apache.flink.streaming.runtime.tasks.OneInputStreamTask$StreamTaskNetworkOutput.processRecord(OneInputStreamTask.java:204)
at org.apache.flink.streaming.runtime.tasks.OneInputStreamTask$StreamTaskNetworkOutput.emitRecord(OneInputStreamTask.java:196)
at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.processElement(StreamTaskNetworkInput.java:151)
at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.emitNext(StreamTaskNetworkInput.java:128)
at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:69)
at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:311)
at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:187)
at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:487)
at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:470)
at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:707)
at org.apache.flink.runtime.taskmanager.Task.run(Task.java:532)
at java.lang.Thread.run(Thread.java:745)
```
and then user modify the parallelism to 1, the job is work, then change to original parallelism, job is work too.
Maybe it's caused by some broken data. But I think the error message should be clearer, not just the ArrayIndexOutOfBoundsException.
Thanks ~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639985108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8953e51d845b3a61608d6e08f9caf462e43775bc",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2856",
"triggerID" : "8953e51d845b3a61608d6e08f9caf462e43775bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8953e51d845b3a61608d6e08f9caf462e43775bc Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 edited a comment on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
carp84 edited a comment on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-644582168
> @carp84 @wuchong I reproduced this case.
> SimpleDateFormat is not thread safe,but a static SimpleDateFormat is used in KeySelector. timestamp changed before and after keyby.
Thanks for the double check @Tartarus0zm . Just to confirm, that from the analysis it sounds like a user error (error usage of `SimpleDateFormat` in customized `KeySelector`) instead of any Flink bug, right? If so, I will merge the hotfix here. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639985108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8953e51d845b3a61608d6e08f9caf462e43775bc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8953e51d845b3a61608d6e08f9caf462e43775bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8953e51d845b3a61608d6e08f9caf462e43775bc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm edited a comment on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm edited a comment on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-643576762
@carp84 thanks for your review first.
in my case, the user custom a KeySelector and the protobuf object that generate the key use Serializer with `immutable` is true.
I only got the error message like this:
```
java.lang.ArrayIndexOutOfBoundsException: -49
at org.apache.flink.runtime.state.heap.KeyGroupPartitionedPriorityQueue.getKeyGroupSubHeapForElement(KeyGroupPartitionedPriorityQueue.java:174)
at org.apache.flink.runtime.state.heap.KeyGroupPartitionedPriorityQueue.add(KeyGroupPartitionedPriorityQueue.java:110)
at org.apache.flink.streaming.api.operators.InternalTimerServiceImpl.registerProcessingTimeTimer(InternalTimerServiceImpl.java:203)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator$Context.registerProcessingTimeTimer(WindowOperator.java:901)
at org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger.onElement(ProcessingTimeTrigger.java:36)
at org.apache.flink.streaming.api.windowing.triggers.ProcessingTimeTrigger.onElement(ProcessingTimeTrigger.java:28)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator$Context.onElement(WindowOperator.java:920)
at org.apache.flink.streaming.runtime.operators.windowing.WindowOperator.processElement(WindowOperator.java:402)
at org.apache.flink.streaming.runtime.tasks.OneInputStreamTask$StreamTaskNetworkOutput.processRecord(OneInputStreamTask.java:204)
at org.apache.flink.streaming.runtime.tasks.OneInputStreamTask$StreamTaskNetworkOutput.emitRecord(OneInputStreamTask.java:196)
at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.processElement(StreamTaskNetworkInput.java:151)
at org.apache.flink.streaming.runtime.io.StreamTaskNetworkInput.emitNext(StreamTaskNetworkInput.java:128)
at org.apache.flink.streaming.runtime.io.StreamOneInputProcessor.processInput(StreamOneInputProcessor.java:69)
at org.apache.flink.streaming.runtime.tasks.StreamTask.processInput(StreamTask.java:311)
at org.apache.flink.streaming.runtime.tasks.mailbox.MailboxProcessor.runMailboxLoop(MailboxProcessor.java:187)
at org.apache.flink.streaming.runtime.tasks.StreamTask.runMailboxLoop(StreamTask.java:487)
at org.apache.flink.streaming.runtime.tasks.StreamTask.invoke(StreamTask.java:470)
at org.apache.flink.runtime.taskmanager.Task.doRun(Task.java:707)
at org.apache.flink.runtime.taskmanager.Task.run(Task.java:532)
at java.lang.Thread.run(Thread.java:745)
```
and then user modify the parallelism to 1, the job is work, then change to original parallelism, job is work too.
Maybe it's caused by some broken data. But I think the error message should be clearer, not just the `ArrayIndexOutOfBoundsException`.
Thanks ~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-644583184
And could you create a JIRA to describe the issue fixed here @Tartarus0zm ? I think that would be easier for later tracking than hotfix. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639979473
cc @carp84 who is more familiar with state module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-643371372
@Tartarus0zm Mind clarify in which case you got the exception in description? While adding the error log is good, I'm just curious whether the exception indicates any more severe bug. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 closed pull request #12508: [FLINK-18332][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
carp84 closed pull request #12508:
URL: https://github.com/apache/flink/pull/12508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-644168403
@carp84 @wuchong I reproduced this case.
SimpleDateFormat is not thread safe,but a static SimpleDateFormat is used in KeySelect. timestamp changed before and after keyby.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-644582168
> @carp84 @wuchong I reproduced this case.
> SimpleDateFormat is not thread safe,but a static SimpleDateFormat is used in KeySelector. timestamp changed before and after keyby.
Thanks for the double check @Tartarus0zm . Just to confirm, that from the analysis it sounds like a user error instead of any Flink bug, right? If so, I will merge the hotfix here. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm edited a comment on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm edited a comment on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-644168403
@carp84 @wuchong I reproduced this case.
SimpleDateFormat is not thread safe,but a static SimpleDateFormat is used in KeySelector. timestamp changed before and after keyby.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12508: [FLINK-18332][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-644769590
@carp84 yes, it's a user error. i has created a JIRA https://issues.apache.org/jira/browse/FLINK-18332, please take a look ~
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639978848
@wuchong can you review this for me if you have time, thanks ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12508: [hotfix][state] Add error message to precondition in KeyGroupPartitio…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12508:
URL: https://github.com/apache/flink/pull/12508#issuecomment-639985108
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8953e51d845b3a61608d6e08f9caf462e43775bc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2856",
"triggerID" : "8953e51d845b3a61608d6e08f9caf462e43775bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8953e51d845b3a61608d6e08f9caf462e43775bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2856)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org