You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2024/04/15 15:16:45 UTC

[PR] Refactor `UnwrapCastInComparison` to use `rewrite()` [arrow-datafusion]

peter-toth opened a new pull request, #10087:
URL: https://github.com/apache/arrow-datafusion/pull/10087

   ## Which issue does this PR close?
   
   Part of https://github.com/apache/arrow-datafusion/issues/9637.
   
   ## Rationale for this change
   
   Eliminates a `LogicalPlan::with_new_exprs()` call and so `Expr` cloning.
   
   ## What changes are included in this PR?
   
   This PR refactors `UnwrapCastInComparison::try_optimize()` to `UnwrapCastInComparison::rewrite()`.
   
   ## Are these changes tested?
   
   Yes, with existing UTs.
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #10087:
URL: https://github.com/apache/arrow-datafusion/pull/10087#issuecomment-2061643740

   @alamb, @jayzhan211 here is a follow-up PR to remove remaining `Expr` clones: https://github.com/apache/arrow-datafusion/pull/10115


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #10087:
URL: https://github.com/apache/arrow-datafusion/pull/10087#issuecomment-2058512917

   > There are still some `Expr` copies left in the actual implementation I noticed, but this gets a bunch of the structural copying out of the way
   
   I will try to eliminate those in a follow-up PR.
   
   Thanks for the review @alamb, @jayzhan211!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 commented on PR #10087:
URL: https://github.com/apache/arrow-datafusion/pull/10087#issuecomment-2058134930

   Thanks @peter-toth 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Refactor `UnwrapCastInComparison` to implement `OptimizerRule::rewrite()` [arrow-datafusion]

Posted by "jayzhan211 (via GitHub)" <gi...@apache.org>.
jayzhan211 merged PR #10087:
URL: https://github.com/apache/arrow-datafusion/pull/10087


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org