[GitHub] [incubator-superset] villebro commented on a change in pull request #10811: fix(mssql): week time grain should respect datefirst setting

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10811:
URL: https://github.com/apache/incubator-superset/pull/10811#discussion_r535202520



##########
File path: superset/db_engine_specs/mssql.py
##########
@@ -46,7 +46,7 @@ class MssqlEngineSpec(BaseEngineSpec):
         "PT0.5H": "DATEADD(minute, DATEDIFF(minute, 0, {col}) / 30 * 30, 0)",
         "PT1H": "DATEADD(hour, DATEDIFF(hour, 0, {col}), 0)",
         "P1D": "DATEADD(day, DATEDIFF(day, 0, {col}), 0)",
-        "P1W": "DATEADD(week, DATEDIFF(week, 0, {col}), 0)",

Review comment:
       You also need to make the changes proposed by the linter:
   ```
   superset/db_engine_specs/mssql.py:54:0: C0301: Line too long (99/88) (line-too-long)
   superset/db_engine_specs/mssql.py:49:0: C0301: Line too long (102/88) (line-too-long)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org