[GitHub] [superset] villebro commented on a diff in pull request #19651: fix(dnd&column): make to fix the blank state issue when only one column select

[GitBox <gi...@apache.org>]

villebro commented on code in PR #19651:
URL: https://github.com/apache/superset/pull/19651#discussion_r848438244


##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx:
##########
@@ -127,14 +127,7 @@ export function DndColumnSelect(props: DndColumnSelectProps) {
   );
 
   const popoverOptions = useMemo(
-    () =>
-      Object.values(options).filter(
-        col =>
-          !optionSelector.values
-            .filter(isColumnMeta)
-            .map((val: ColumnMeta) => val.column_name)
-            .includes(col.column_name),
-      ),
+    () => Object.values(options),
     [optionSelector.values, options],

Review Comment:
   Isn't `optionSelector` redundant in the dependency array after this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org