You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2015/12/04 13:20:21 UTC

ios commit: CB-10136 - error in cordova prepare (Platform API)

Repository: cordova-ios
Updated Branches:
  refs/heads/master 8d4196f77 -> e788aa2ff


CB-10136 - error in cordova prepare (Platform API)


Project: http://git-wip-us.apache.org/repos/asf/cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-ios/commit/e788aa2f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-ios/tree/e788aa2f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-ios/diff/e788aa2f

Branch: refs/heads/master
Commit: e788aa2ffdb6da09e7262be48efa36250a440dff
Parents: 8d4196f
Author: Shazron Abdullah <sh...@apache.org>
Authored: Fri Dec 4 04:20:17 2015 -0800
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Fri Dec 4 04:20:17 2015 -0800

----------------------------------------------------------------------
 bin/templates/scripts/cordova/lib/prepare.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-ios/blob/e788aa2f/bin/templates/scripts/cordova/lib/prepare.js
----------------------------------------------------------------------
diff --git a/bin/templates/scripts/cordova/lib/prepare.js b/bin/templates/scripts/cordova/lib/prepare.js
index e5637ed..0485e32 100644
--- a/bin/templates/scripts/cordova/lib/prepare.js
+++ b/bin/templates/scripts/cordova/lib/prepare.js
@@ -160,7 +160,7 @@ function updateProject(platformConfig, locations) {
     events.emit('verbose', 'Wrote out iOS Bundle Identifier to "' + pkg + '"');
     events.emit('verbose', 'Wrote out iOS Bundle Version to "' + version + '"');
 
-    return handleBuildSettings(platformConfig).then(function() {
+    return handleBuildSettings(platformConfig, locations).then(function() {
         if (name == originalName) {
             events.emit('verbose', 'iOS Product Name has not changed (still "' + originalName + '")');
             return Q();
@@ -225,7 +225,7 @@ function handleOrientationSettings(platformConfig, infoPlist) {
     }
 }
 
-function handleBuildSettings(platformConfig) {
+function handleBuildSettings(platformConfig, locations) {
     var targetDevice = parseTargetDevicePreference(platformConfig.getPreference('target-device', 'ios'));
     var deploymentTarget = platformConfig.getPreference('deployment-target', 'ios');
 
@@ -234,7 +234,7 @@ function handleBuildSettings(platformConfig) {
         return Q();
     }
 
-    var proj = new xcode.project(this.pbxproj);
+    var proj = new xcode.project(locations.pbxproj);
 
     try {
         proj.parseSync();
@@ -252,7 +252,7 @@ function handleBuildSettings(platformConfig) {
         proj.updateBuildProperty('IPHONEOS_DEPLOYMENT_TARGET', deploymentTarget);
     }
 
-    fs.writeFileSync(this.pbxproj, proj.writeSync(), 'utf-8');
+    fs.writeFileSync(locations.pbxproj, proj.writeSync(), 'utf-8');
 
     return Q();
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org