You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/22 23:20:15 UTC

[GitHub] [airflow] Taragolis commented on pull request #28484: Add execution role parameter to AddStepsOperator

Taragolis commented on PR #28484:
URL: https://github.com/apache/airflow/pull/28484#issuecomment-1363431974

   >Made a minor change with how the new parameter gets used in the hook. Because we are using @mock_emr decorator in some of the tests, it applies boto3 validation rules on the parameters passed, which include no None values, as well as a minimum length (otherwise I could have done a simpler ExecutionRoleArn=execution_role_arn or "").
   
   I think this originally comes from `botocore` service definition, example for input of [AddJobFlowStepsInput](https://github.com/boto/botocore/blob/e5a2878a90d28e77d09126579e9f131a4611fb3d/botocore/data/emr/2009-03-31/service-2.json#L775-L794).
   
   I've also found that if set some of optional parameters set to `None` or empty string then `botocore` do not propagate it to API call but sometimes it raise an error `¯\_(ツ)_/¯`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org