You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "exceptionfactory (via GitHub)" <gi...@apache.org> on 2023/10/27 20:03:10 UTC

[PR] NIFI-12287 Standardize skipping Source and Javadoc for NAR modules [nifi]

exceptionfactory opened a new pull request, #7947:
URL: https://github.com/apache/nifi/pull/7947

   # Summary
   
   [NIFI-12287](https://issues.apache.org/jira/browse/NIFI-12287) Standardizes skipping of Sources and Javadoc JAR generation for NAR and WAR modules.
   
   Modern versions of the Maven Source Plugin use `maven.source.skip` as the property name for skipping sources. As a result of historical usage of `source.skip` properties in individual NAR files, recent releases published sources JAR files for each NAR.
   
   Changes include adding `nar-packaging` and `war-packaging` profiles to the root Maven configuration, setting `maven.source.skip` and `maven.javadoc.skip` to `true` for the `nar` and `war` packaging types. Centralizing this configuration removes the need for setting these properties in individual NAR configurations.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] NIFI-12287 Standardize skipping Source and Javadoc for NAR modules [nifi]

Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #7947: NIFI-12287 Standardize skipping Source and Javadoc for NAR modules
URL: https://github.com/apache/nifi/pull/7947


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org