You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2013/11/01 01:04:08 UTC
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 12:04 a.m.)
Review request for mesos and BenjaminVW BenjaminVW.
Changes
-------
Minified marked.js
Repository: mesos-git
Description
-------
Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 65b0590
src/Makefile.am a11c76b
src/webui/master/static/js/marked.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/14940/diff/
Testing
-------
make check
And functional testing of /help endpoints.
Thanks,
Niklas Nielsen
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review28022
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Nov. 1, 2013, 12:04 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:04 a.m.)
>
>
> Review request for mesos and BenjaminVW BenjaminVW.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review28027
-----------------------------------------------------------
No more jQuery download, no more GitHub API request. These pages are super fast now.
Tested and committed to master.
- Ross Allen
On Nov. 1, 2013, 6:08 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 6:08 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On Jan. 15, 2014, 2:25 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/help.hpp, line 246
> > <https://reviews.apache.org/r/14940/diff/4/?file=376597#file376597line246>
> >
> > Shoot, looks like this doesn't work for the slaves, since hitting /help on the slave will attempt to load this master-only script.
> >
> > Since /help is for any libprocess binary, we should figure out how to make this work in the general case.
> >
> > Filed: https://issues.apache.org/jira/browse/MESOS-913
Ah - bummer. Will take a look at it.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review31949
-----------------------------------------------------------
On Nov. 1, 2013, 11:08 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 11:08 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review31949
-----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/14940/#comment60712>
Shoot, looks like this doesn't work for the slaves, since hitting /help on the slave will attempt to load this master-only script.
Since /help is for any libprocess binary, we should figure out how to make this work in the general case.
Filed: https://issues.apache.org/jira/browse/MESOS-913
- Ben Mahler
On Nov. 1, 2013, 6:08 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 6:08 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review28026
-----------------------------------------------------------
Ship it!
Ship It!
- Ross Allen
On Nov. 1, 2013, 6:08 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 6:08 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 6:08 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 65b0590
src/Makefile.am a11c76b
src/webui/master/static/js/marked.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/14940/diff/
Testing
-------
make check
And functional testing of /help endpoints.
Thanks,
Niklas Nielsen
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/
-----------------------------------------------------------
(Updated Nov. 1, 2013, 6:01 p.m.)
Review request for mesos and BenjaminVW BenjaminVW.
Changes
-------
- Removed jQuery dependencies.
Repository: mesos-git
Description
-------
Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 65b0590
src/Makefile.am a11c76b
src/webui/master/static/js/marked.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/14940/diff/
Testing
-------
make check
And functional testing of /help endpoints.
Thanks,
Niklas Nielsen
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Ross Allen <ro...@mesosphere.io>.
> On Nov. 1, 2013, 5:42 p.m., Ross Allen wrote:
> > 3rdparty/libprocess/include/process/help.hpp, line 246
> > <https://reviews.apache.org/r/14940/diff/3/?file=375921#file375921line246>
> >
> > Since jQuery is no longer removed, can you remove this <script> tag and the variable assignment above?
Whoops, can't type.
Since jQuery is no longer used*
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review28023
-----------------------------------------------------------
On Nov. 1, 2013, 12:04 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:04 a.m.)
>
>
> Review request for mesos and BenjaminVW BenjaminVW.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review28023
-----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/14940/#comment54490>
Since jQuery is no longer removed, can you remove this <script> tag and the variable assignment above?
- Ross Allen
On Nov. 1, 2013, 12:04 a.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
>
> (Updated Nov. 1, 2013, 12:04 a.m.)
>
>
> Review request for mesos and BenjaminVW BenjaminVW.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with help is excessively used on a shared IP due to api quota rules.
>
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked) and replaces the github api call.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 65b0590
> src/Makefile.am a11c76b
> src/webui/master/static/js/marked.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14940/diff/
>
>
> Testing
> -------
>
> make check
>
> And functional testing of /help endpoints.
>
>
> Thanks,
>
> Niklas Nielsen
>
>