You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/05/29 19:05:59 UTC
[GitHub] [helix] mgao0 opened a new pull request #1038: Clean up lock module dependencies
mgao0 opened a new pull request #1038:
URL: https://github.com/apache/helix/pull/1038
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Current ivy file and pom.xml in helix-lock module contain some unnecessary dependencies. This PR cleans up these dependencies.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
Removed snakeyaml from ivy file.
Removed snakeyaml, commons-lang3, httpclient, xstream from pom.xml
### Tests
- [ ] The following is the result of the "mvn test" command on the appropriate module:
helix-lock module
[INFO] Results:
[INFO]
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:23 min
[INFO] Finished at: 2020-05-29T11:50:59-07:00
[INFO] ------------------------------------------------------------------------
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] mgao0 commented on pull request #1038: Clean up lock module dependencies
Posted by GitBox <gi...@apache.org>.
mgao0 commented on pull request #1038:
URL: https://github.com/apache/helix/pull/1038#issuecomment-636159369
This PR is ready to be merged, approved by @narendly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #1038: Clean up lock module dependencies
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #1038:
URL: https://github.com/apache/helix/pull/1038
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org