You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2020/07/04 11:44:16 UTC

[commons-geometry] 08/11: change a field to local variable, as I didn't see anywhere using it.

This is an automated email from the ASF dual-hosted git repository.

mattjuntunen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit 6c90e34ff11fb9fa279d9b060abf70c14ce3cd2a
Author: XenoAmess <xe...@gmail.com>
AuthorDate: Sat Jul 4 09:47:06 2020 +0800

    change a field to local variable, as I didn't see anywhere using it.
---
 .../java/org/apache/commons/geometry/euclidean/threed/Planes.java  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java
index dfde9e3..721d729 100644
--- a/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java
+++ b/commons-geometry-euclidean/src/main/java/org/apache/commons/geometry/euclidean/threed/Planes.java
@@ -786,9 +786,6 @@ public final class Planes {
         /** Base plane to extrude from. */
         private final EmbeddingPlane basePlane;
 
-        /** Extruded plane; this forms the end of the 3D region opposite the base plane. */
-        private final EmbeddingPlane extrudedPlane;
-
         /** Vector to extrude along; the extruded plane is translated from the base plane by this amount. */
         private final Vector3D extrusionVector;
 
@@ -809,7 +806,9 @@ public final class Planes {
                 final DoublePrecisionContext precision) {
 
             this.basePlane = basePlane;
-            this.extrudedPlane = basePlane.translate(extrusionVector);
+
+            // Extruded plane; this forms the end of the 3D region opposite the base plane.
+            EmbeddingPlane extrudedPlane = basePlane.translate(extrusionVector);
 
             if (basePlane.contains(extrudedPlane)) {
                 throw new IllegalArgumentException(