You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/19 01:55:21 UTC
[GitHub] [pulsar] limingnihao opened a new pull request #9618: [Issue 9535] Add metrics for the cursor ack state
limingnihao opened a new pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618
Fixes #9535
### Motivation
The acknowledgment state is persistent to the Ledger or Zookeeper(can't persistent to the Ledger). But currently, we don't have any metrics for the persistence of the acknowledgment state such as the total count of the success/failed persistent operations.
### Modifications
Add metrics for the ManagedCursor:
brk_ml_cursor_persistLedgerSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistLedgerErrors(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperSucceed(namespace="", ledger_name="", cursor_name:"")
brk_ml_cursor_persistZookeeperErrors(namespace="", ledger_name="", cursor_name:"")
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782523428
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao removed a comment on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao removed a comment on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782523428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782118373
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782161339
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-781922250
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-781963502
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782548948
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782081680
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao removed a comment on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao removed a comment on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-781964129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-784654980
@limingnihao thanks for your coding work, would you like to add docs for this change as well? I'd like to help review. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-785504325
@limingnihao any thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-781932208
`/pulsarbot run-failure-checks`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782008610
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782081350
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782008525
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782545220
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao removed a comment on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao removed a comment on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782564427
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao removed a comment on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao removed a comment on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782008525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao removed a comment on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao removed a comment on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-781932208
`/pulsarbot run-failure-checks`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782564427
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao removed a comment on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao removed a comment on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-782081350
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] limingnihao commented on pull request #9618: [Issue 9535] Add metrics for the cursor ack state
Posted by GitBox <gi...@apache.org>.
limingnihao commented on pull request #9618:
URL: https://github.com/apache/pulsar/pull/9618#issuecomment-781964129
pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org