You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/06 17:43:36 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg

kaxil commented on a change in pull request #7082: [AIRFLOW-XXXX] Add useful tips to first PR msg
URL: https://github.com/apache/airflow/pull/7082#discussion_r363402379
 
 

 ##########
 File path: .github/boring-cyborg.yml
 ##########
 @@ -152,6 +152,18 @@ firstPRWelcomeComment: |
   If you have any issues or are unsure about any anything please check our
   Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
 
+  Here are some useful points:
+  - Check the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
+  https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
+  will help you with that.
+  - In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
+  Adding a new operator? Consider adding an example DAG that shows how users should use it.
+  - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst), it’s a
+  heavy docker but it ships with a working Airflow and a lot of integrations.
+  - Be patient and persistent.
 
 Review comment:
   ```suggestion
     - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services