You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ma...@apache.org on 2019/03/11 18:17:15 UTC
[kafka] branch trunk updated: MINOR: Update delete topics zk path
in assertion error messages
This is an automated email from the ASF dual-hosted git repository.
manikumar pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 1e1b669 MINOR: Update delete topics zk path in assertion error messages
1e1b669 is described below
commit 1e1b669e9d3aa94773924909d154cad191cfde93
Author: huxihx <hu...@hotmail.com>
AuthorDate: Mon Mar 11 23:46:49 2019 +0530
MINOR: Update delete topics zk path in assertion error messages
- Update delete topics zk path from /admin/delete_topic to /admin/delete_topics in assertion error
messages
Author: huxihx <hu...@hotmail.com>
Reviewers: Manikumar Reddy <ma...@gmail.com>
Closes #6422 from huxihx/delete-topics
---
core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala | 6 +++---
core/src/test/scala/unit/kafka/utils/TestUtils.scala | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala b/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
index 3f3e754..6e5ffc8 100644
--- a/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
+++ b/core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala
@@ -69,7 +69,7 @@ class DeleteTopicTest extends ZooKeeperTestHarness {
.forall(_.getLogManager().getLog(topicPartition).isEmpty), "Replicas 0,1 have not deleted log.")
// ensure topic deletion is halted
TestUtils.waitUntilTrue(() => zkClient.isTopicMarkedForDeletion(topic),
- "Admin path /admin/delete_topic/test path deleted even when a follower replica is down")
+ "Admin path /admin/delete_topics/test path deleted even when a follower replica is down")
// restart follower replica
follower.startup()
TestUtils.verifyTopicDeletion(zkClient, topic, 1, servers)
@@ -93,7 +93,7 @@ class DeleteTopicTest extends ZooKeeperTestHarness {
// ensure topic deletion is halted
TestUtils.waitUntilTrue(() => zkClient.isTopicMarkedForDeletion(topic),
- "Admin path /admin/delete_topic/test path deleted even when a replica is down")
+ "Admin path /admin/delete_topics/test path deleted even when a replica is down")
controller.startup()
follower.startup()
@@ -397,7 +397,7 @@ class DeleteTopicTest extends ZooKeeperTestHarness {
// mark the topic for deletion
adminZkClient.deleteTopic("test")
TestUtils.waitUntilTrue(() => !zkClient.isTopicMarkedForDeletion(topic),
- "Admin path /admin/delete_topic/%s path not deleted even if deleteTopic is disabled".format(topic))
+ "Admin path /admin/delete_topics/%s path not deleted even if deleteTopic is disabled".format(topic))
// verify that topic test is untouched
assertTrue(servers.forall(_.getLogManager().getLog(topicPartition).isDefined))
// test the topic path exists
diff --git a/core/src/test/scala/unit/kafka/utils/TestUtils.scala b/core/src/test/scala/unit/kafka/utils/TestUtils.scala
index 8b8b230..5dc7c8a 100755
--- a/core/src/test/scala/unit/kafka/utils/TestUtils.scala
+++ b/core/src/test/scala/unit/kafka/utils/TestUtils.scala
@@ -1054,9 +1054,9 @@ object TestUtils extends Logging {
val topicPartitions = (0 until numPartitions).map(new TopicPartition(topic, _))
// wait until admin path for delete topic is deleted, signaling completion of topic deletion
TestUtils.waitUntilTrue(() => !zkClient.isTopicMarkedForDeletion(topic),
- "Admin path /admin/delete_topic/%s path not deleted even after a replica is restarted".format(topic))
+ "Admin path /admin/delete_topics/%s path not deleted even after a replica is restarted".format(topic))
TestUtils.waitUntilTrue(() => !zkClient.topicExists(topic),
- "Topic path /brokers/topics/%s not deleted after /admin/delete_topic/%s path is deleted".format(topic, topic))
+ "Topic path /brokers/topics/%s not deleted after /admin/delete_topics/%s path is deleted".format(topic, topic))
// ensure that the topic-partition has been deleted from all brokers' replica managers
TestUtils.waitUntilTrue(() =>
servers.forall(server => topicPartitions.forall(tp => server.replicaManager.getPartition(tp).isEmpty)),