You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2021/03/01 05:19:57 UTC

[GitHub] [incubator-hop] HiromuHota commented on pull request #653: HOP-2564: Resolve filterPath to resolve ${HOP_CONFIG_FOLDER}

HiromuHota commented on pull request #653:
URL: https://github.com/apache/incubator-hop/pull/653#issuecomment-787645350


   @hansva @mattcasters
   First I tried to resolve `homeFolder` at `org.apache.hop.projects.xp.HopGuiFileDefaultFolder.callExtensionPoint(ILogChannel, IVariables, HopGuiFileDialogExtension)`, but the `variables` was null.
   Instead the PR currently resolves it at `org.apache.hop.ui.core.vfs.HopVfsFileDialog.setFilterPath(String)`, which works fine, but I'm not sure if this is the right place to resolve it.
   Where do you think should it be resolved?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org