You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openjpa.apache.org by GitBox <gi...@apache.org> on 2021/10/22 03:40:08 UTC

[GitHub] [openjpa] solomax commented on pull request #84: [OPENJPA-2883] 'supportsAutoAssign' is turned OFF when 'useTriggersForAutoAssign' is ON

solomax commented on pull request #84:
URL: https://github.com/apache/openjpa/pull/84#issuecomment-949260287


   Thanks for the review @rmannibucau 
   
   1. should be improved :)
   2. While I would agree with this point I see couple of possible explanations :)))
   
       - in this particular case user explicitly specifies `UseTriggersForAutoAssign` while `supportsAutoAssign` is auto-set in the code
       - these two can't be enabled simultaneously :((( please see the description in JIRA
       - I believe this issue is simple typo, so I tried to create very simple fix :)))
   
   Would be happy to further improve this PR :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openjpa.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org