You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Glen Mazza (JIRA)" <ji...@apache.org> on 2011/07/07 12:33:16 UTC

[jira] [Created] (ZOOKEEPER-1119) zkServer stop command incorrectly reading commented-out dataDirs in zoo.cfg

zkServer stop command incorrectly reading commented-out dataDirs in zoo.cfg
---------------------------------------------------------------------------

                 Key: ZOOKEEPER-1119
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
             Project: ZooKeeper
          Issue Type: Bug
          Components: scripts
    Affects Versions: 3.3.3
         Environment: Ubuntu Linux 10.04, JDK 6
            Reporter: Glen Mazza


Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):

# the directory where the snapshot is stored.
# dataDir=test123/data
dataDir=/export/crawlspace/mahadev/zookeeper/server1/data

and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:

gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
JMX enabled by default
Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
Stopping zookeeper ... 
error: could not find file test123/data
/export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 

If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
error: could not find file test123456/data

showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-1119:
------------------------------------

    Attachment: ZOOKEEPER-1119.patch

this fixes the problem identified, for all scripts I could find. we were using grep on the config file w/o ignoring commented out lines. This patch only looks for uncommented dataDir (etc...).

> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>         Attachments: ZOOKEEPER-1119.patch
>
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated ZOOKEEPER-1119:
---------------------------------

    Attachment:     (was: ZOOKEEPER-999-10.patch)

> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1119.patch
>
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071034#comment-13071034 ] 

Hudson commented on ZOOKEEPER-1119:
-----------------------------------

Integrated in ZooKeeper-trunk #1255 (See [https://builds.apache.org/job/ZooKeeper-trunk/1255/])
    ZOOKEEPER-1119. zkServer stop command incorrectly reading comment lines in zoo.cfg (phunt via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150937
Files : 
* /zookeeper/trunk/bin/zkCleanup.sh
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/bin/zkServer.sh


> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1119.patch
>
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Eric Yang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eric Yang updated ZOOKEEPER-1119:
---------------------------------

    Attachment: ZOOKEEPER-999-10.patch

Sync up with trunk 

> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1119.patch, ZOOKEEPER-999-10.patch
>
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-1119:
---------------------------------------

    Assignee: Patrick Hunt

> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1119.patch
>
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Glen Mazza updated ZOOKEEPER-1119:
----------------------------------

    Summary: zkServer stop command incorrectly reading comment lines in zoo.cfg  (was: zkServer stop command incorrectly reading commented-out dataDirs in zoo.cfg)

> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-1119:
------------------------------------

    Description: 
Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):

{noformat}
# the directory where the snapshot is stored.
# dataDir=test123/data
dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
{noformat}

and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:

{noformat}
gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
JMX enabled by default
Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
Stopping zookeeper ... 
error: could not find file test123/data
/export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
{noformat}

If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
error: could not find file test123456/data

showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)


  was:
Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):

{noformat}
# the directory where the snapshot is stored.
# dataDir=test123/data
dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
{noformat}

and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:

gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
JMX enabled by default
Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
Stopping zookeeper ... 
error: could not find file test123/data
/export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 

If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
error: could not find file test123456/data

showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)



> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-1119:
------------------------------------

    Description: 
Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):

{noformat}
# the directory where the snapshot is stored.
# dataDir=test123/data
dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
{noformat}

and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:

gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
JMX enabled by default
Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
Stopping zookeeper ... 
error: could not find file test123/data
/export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 

If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
error: could not find file test123456/data

showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)


  was:
Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):

# the directory where the snapshot is stored.
# dataDir=test123/data
dataDir=/export/crawlspace/mahadev/zookeeper/server1/data

and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:

gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
JMX enabled by default
Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
Stopping zookeeper ... 
error: could not find file test123/data
/export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 

If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
error: could not find file test123456/data

showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)



> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1119) zkServer stop command incorrectly reading comment lines in zoo.cfg

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061579#comment-13061579 ] 

Hadoop QA commented on ZOOKEEPER-1119:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12485650/ZOOKEEPER-1119.patch
  against trunk revision 1143688.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/379//console

This message is automatically generated.

> zkServer stop command incorrectly reading comment lines in zoo.cfg
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1119
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1119
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 3.3.3
>         Environment: Ubuntu Linux 10.04, JDK 6
>            Reporter: Glen Mazza
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1119.patch
>
>
> Hello, adding the following commented-out dataDir to the zoo.cfg file (keeping the default one provided active):
> {noformat}
> # the directory where the snapshot is stored.
> # dataDir=test123/data
> dataDir=/export/crawlspace/mahadev/zookeeper/server1/data
> {noformat}
> and then running sh zkServer.sh stop is showing that the program is incorrectly reading the commented-out dataDir:
> {noformat}
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ sh zkServer.sh stop
> JMX enabled by default
> Using config: /media/NewDriveExt3_/apps/zookeeper-3.3.3/bin/../conf/zoo.cfg
> Stopping zookeeper ... 
> error: could not find file test123/data
> /export/crawlspace/mahadev/zookeeper/server1/data/zookeeper_server.pid
> gmazza@gmazza-work:~/dataExt3/apps/zookeeper-3.3.3/bin$ 
> {noformat}
> If I change the commented-out line in zoo.cfg to "test123456/data" and run the stop command again I get:
> error: could not find file test123456/data
> showing that it's incorrectly doing a run-time read of the commented-out lines.  (Difficult to completely confirm, but this problem  doesn't appear to occur with the start command, only the stop one.)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira