You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Grzegorz Slowikowski (JIRA)" <ji...@codehaus.org> on 2006/02/02 16:31:16 UTC

[jira] Created: (MNG-2032) Bug in dependency exclusions processing (ArtifactFilter's)

Bug in dependency exclusions processing (ArtifactFilter's)
----------------------------------------------------------

         Key: MNG-2032
         URL: http://jira.codehaus.org/browse/MNG-2032
     Project: Maven 2
        Type: Bug

  Components: Dependencies  
    Versions: 2.0.1    
    Reporter: Grzegorz Slowikowski


I thing, I found an error in dependency exclusions calculations.
For pom dependencies:

  <dependencies>
    <dependency>
      <groupId>struts</groupId>
      <artifactId>struts</artifactId>
      <version>1.2.8</version>
      <exclusions>
        <exclusion>
          <groupId>javax.servlet</groupId>
          <artifactId>servlet-api</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

    <dependency>
      <groupId>jfree</groupId>
      <artifactId>jfreechart</artifactId>
      <version>1.0.0</version>
      <exclusions>
        <exclusion>
          <groupId>gnujaxp</groupId>
          <artifactId>gnujaxp</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
  </dependencies>

in method MavenMetadataSource.createArtifacts the two above dependencies are processed and ArtifactFilters are applied. The first dependency (struts) gets ExcludesArtifactFilter( "javax.servlet:servlet-api" ) - this is OK, but
the second dependency (jfreechart) gets wrong filter - AndArtifactFilter which concatenates ExcludesArtifactFilter( "gnujaxp:gnujaxp" ) with ExcludesArtifactFilter( "javax.servlet:servlet-api" ). This second ExcludesArtifactFilter comes from the first dependency (struts). Method parameter "dependencyFilter" is overridden when processing the first dependency and read when processing the second one. The fix should be simple.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[jira] Closed: (MNG-2032) Bug in dependency exclusions processing (ArtifactFilter's)

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2032?page=all ]
     
Brett Porter closed MNG-2032:
-----------------------------

     Assign To: Brett Porter
    Resolution: Duplicate

> Bug in dependency exclusions processing (ArtifactFilter's)
> ----------------------------------------------------------
>
>          Key: MNG-2032
>          URL: http://jira.codehaus.org/browse/MNG-2032
>      Project: Maven 2
>         Type: Bug

>   Components: Dependencies
>     Versions: 2.0.2
>     Reporter: Grzegorz Slowikowski
>     Assignee: Brett Porter

>
>
> I thing, I found an error in dependency exclusions calculations.
> For pom dependencies:
>   <dependencies>
>     <dependency>
>       <groupId>struts</groupId>
>       <artifactId>struts</artifactId>
>       <version>1.2.8</version>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.servlet</groupId>
>           <artifactId>servlet-api</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>     <dependency>
>       <groupId>jfree</groupId>
>       <artifactId>jfreechart</artifactId>
>       <version>1.0.0</version>
>       <exclusions>
>         <exclusion>
>           <groupId>gnujaxp</groupId>
>           <artifactId>gnujaxp</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> in method MavenMetadataSource.createArtifacts the two above dependencies are processed and ArtifactFilters are applied. The first dependency (struts) gets ExcludesArtifactFilter( "javax.servlet:servlet-api" ) - this is OK, but
> the second dependency (jfreechart) gets wrong filter - AndArtifactFilter which concatenates ExcludesArtifactFilter( "gnujaxp:gnujaxp" ) with ExcludesArtifactFilter( "javax.servlet:servlet-api" ). This second ExcludesArtifactFilter comes from the first dependency (struts). Method parameter "dependencyFilter" is overridden when processing the first dependency and read when processing the second one. The fix should be simple.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[jira] Commented: (MNG-2032) Bug in dependency exclusions processing (ArtifactFilter's)

Posted by "Grzegorz Slowikowski (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-2032?page=comments#action_57635 ] 

Grzegorz Slowikowski commented on MNG-2032:
-------------------------------------------

Sholud be Maven 2.0.2, not 2.0.1

> Bug in dependency exclusions processing (ArtifactFilter's)
> ----------------------------------------------------------
>
>          Key: MNG-2032
>          URL: http://jira.codehaus.org/browse/MNG-2032
>      Project: Maven 2
>         Type: Bug

>   Components: Dependencies
>     Versions: 2.0.1
>     Reporter: Grzegorz Slowikowski

>
>
> I thing, I found an error in dependency exclusions calculations.
> For pom dependencies:
>   <dependencies>
>     <dependency>
>       <groupId>struts</groupId>
>       <artifactId>struts</artifactId>
>       <version>1.2.8</version>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.servlet</groupId>
>           <artifactId>servlet-api</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>     <dependency>
>       <groupId>jfree</groupId>
>       <artifactId>jfreechart</artifactId>
>       <version>1.0.0</version>
>       <exclusions>
>         <exclusion>
>           <groupId>gnujaxp</groupId>
>           <artifactId>gnujaxp</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> in method MavenMetadataSource.createArtifacts the two above dependencies are processed and ArtifactFilters are applied. The first dependency (struts) gets ExcludesArtifactFilter( "javax.servlet:servlet-api" ) - this is OK, but
> the second dependency (jfreechart) gets wrong filter - AndArtifactFilter which concatenates ExcludesArtifactFilter( "gnujaxp:gnujaxp" ) with ExcludesArtifactFilter( "javax.servlet:servlet-api" ). This second ExcludesArtifactFilter comes from the first dependency (struts). Method parameter "dependencyFilter" is overridden when processing the first dependency and read when processing the second one. The fix should be simple.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[jira] Updated: (MNG-2032) Bug in dependency exclusions processing (ArtifactFilter's)

Posted by "Carlos Sanchez (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-2032?page=all ]

Carlos Sanchez updated MNG-2032:
--------------------------------

    Version:     (was: 2.0.1)
             2.0.2

> Bug in dependency exclusions processing (ArtifactFilter's)
> ----------------------------------------------------------
>
>          Key: MNG-2032
>          URL: http://jira.codehaus.org/browse/MNG-2032
>      Project: Maven 2
>         Type: Bug

>   Components: Dependencies
>     Versions: 2.0.2
>     Reporter: Grzegorz Slowikowski

>
>
> I thing, I found an error in dependency exclusions calculations.
> For pom dependencies:
>   <dependencies>
>     <dependency>
>       <groupId>struts</groupId>
>       <artifactId>struts</artifactId>
>       <version>1.2.8</version>
>       <exclusions>
>         <exclusion>
>           <groupId>javax.servlet</groupId>
>           <artifactId>servlet-api</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>     <dependency>
>       <groupId>jfree</groupId>
>       <artifactId>jfreechart</artifactId>
>       <version>1.0.0</version>
>       <exclusions>
>         <exclusion>
>           <groupId>gnujaxp</groupId>
>           <artifactId>gnujaxp</artifactId>
>         </exclusion>
>       </exclusions>
>     </dependency>
>   </dependencies>
> in method MavenMetadataSource.createArtifacts the two above dependencies are processed and ArtifactFilters are applied. The first dependency (struts) gets ExcludesArtifactFilter( "javax.servlet:servlet-api" ) - this is OK, but
> the second dependency (jfreechart) gets wrong filter - AndArtifactFilter which concatenates ExcludesArtifactFilter( "gnujaxp:gnujaxp" ) with ExcludesArtifactFilter( "javax.servlet:servlet-api" ). This second ExcludesArtifactFilter comes from the first dependency (struts). Method parameter "dependencyFilter" is overridden when processing the first dependency and read when processing the second one. The fix should be simple.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org