You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by "NicolasGong (via GitHub)" <gi...@apache.org> on 2023/03/31 11:41:36 UTC
[GitHub] [zeppelin] NicolasGong opened a new pull request, #4578: Method contains useless variables
NicolasGong opened a new pull request, #4578:
URL: https://github.com/apache/zeppelin/pull/4578
### What is this PR for?
Method contains useless variables
### What type of PR is it?
Improvement
### What is the Jira issue?
* [ZEPPELIN-5891]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on code in PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#discussion_r1159526125
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java:
##########
@@ -93,12 +93,7 @@ public void createNoteAuth(String noteId, AuthenticationInfo subject) {
NoteAuth noteAuth = new NoteAuth(noteId, subject, conf);
this.notesAuth.put(noteId, noteAuth);
}
-
- public void cloneNoteMeta(String noteId, String sourceNoteId, AuthenticationInfo subject) {
- NoteAuth noteAuth = new NoteAuth(noteId, subject, conf);
- this.notesAuth.put(noteId, noteAuth);
- }
-
+
Review Comment:
I suspect spaces here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on a diff in pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "NicolasGong (via GitHub)" <gi...@apache.org>.
NicolasGong commented on code in PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#discussion_r1160369614
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/AuthorizationService.java:
##########
@@ -93,12 +93,7 @@ public void createNoteAuth(String noteId, AuthenticationInfo subject) {
NoteAuth noteAuth = new NoteAuth(noteId, subject, conf);
this.notesAuth.put(noteId, noteAuth);
}
-
- public void cloneNoteMeta(String noteId, String sourceNoteId, AuthenticationInfo subject) {
- NoteAuth noteAuth = new NoteAuth(noteId, subject, conf);
- this.notesAuth.put(noteId, noteAuth);
- }
-
+
Review Comment:
I removed extra spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer merged PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1495667645
I think we can delete the `cloneNoteMeta` method completely and replace it with `createNoteAuth`.
In my opinion, the original rights should not be transferred from the old Note to the new Note. It makes sense to store the roles of the user who is currently cloning the note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "NicolasGong (via GitHub)" <gi...@apache.org>.
NicolasGong commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1501294629
Some checks were not successful,but i don't know why. These errors do not appear to be related to this commit。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "NicolasGong (via GitHub)" <gi...@apache.org>.
NicolasGong commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1495285576
> Very strange, we want to clone the metadata. How does the code work without a source NoteId?
I think this method is to put the new NoteId and AuthenticationInfo into the cache. This method does not require sourceNoteId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1494169052
Very strange, we want to clone the metadata. How does the code work without a source NoteId?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] NicolasGong commented on pull request #4578: [ZEPPELIN-5891] Method contains useless variables
Posted by "NicolasGong (via GitHub)" <gi...@apache.org>.
NicolasGong commented on PR #4578:
URL: https://github.com/apache/zeppelin/pull/4578#issuecomment-1498391860
I agree with you and resubmitted the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org