You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/04/07 09:57:00 UTC
[jira] [Work logged] (HIVE-23571) [CachedStore] Add
ValidWriteIdList to SharedCache.TableWrapper
[ https://issues.apache.org/jira/browse/HIVE-23571?focusedWorklogId=578252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578252 ]
ASF GitHub Bot logged work on HIVE-23571:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/21 09:56
Start Date: 07/Apr/21 09:56
Worklog Time Spent: 10m
Work Description: adesh-rao commented on a change in pull request #2128:
URL: https://github.com/apache/hive/pull/2128#discussion_r608511275
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java
##########
@@ -2476,6 +2499,25 @@ public boolean isTableConstraintValid(String catName, String dbName, String tblN
return isValid;
}
+ public boolean isTableCacheStale(String catName, String dbName, String tblName, String validWriteIdList) {
+ boolean isValid = false;
+
+ if (StringUtils.isEmpty(validWriteIdList))
+ return false;
Review comment:
nit: add braces.
Also, should we return true? if validWriteId is not present, we can safely assume that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 578252)
Time Spent: 20m (was: 10m)
> [CachedStore] Add ValidWriteIdList to SharedCache.TableWrapper
> --------------------------------------------------------------
>
> Key: HIVE-23571
> URL: https://issues.apache.org/jira/browse/HIVE-23571
> Project: Hive
> Issue Type: Sub-task
> Reporter: Kishen Das
> Assignee: Ashish Sharma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add ValidWriteIdList to SharedCache.TableWrapper. This would be used in deciding whether a given read request can be served from the cache or we have to reload it from the backing database.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)