You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/10 17:37:48 UTC

[GitHub] [flink] bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table

bowenli86 commented on a change in pull request #8614: [FLINK-12727][hive] Make HiveTableOutputFormat support writing partitioned table
URL: https://github.com/apache/flink/pull/8614#discussion_r290503595
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableOutputFormat.java
 ##########
 @@ -118,6 +123,9 @@
 	// Writer for non-partitioned and static partitioned table
 	private transient HivePartitionWriter staticWriter;
 
+	// the offset of dynamic partition columns within a row
+	private transient int dynPartOffset;
 
 Review comment:
   can we use full name for variables? here, as well as variable names thru out this file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services