[GitHub] [ignite] alex-plekhanov commented on a change in pull request #7616: IGNITE-12853: Introduced features for the thin client protocol

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #7616: IGNITE-12853: Introduced features for the thin client protocol
URL: https://github.com/apache/ignite/pull/7616#discussion_r403928153
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformConfigurationUtils.java
 ##########
 @@ -166,10 +165,10 @@ public static void writeDotNetConfiguration(BinaryRawWriterEx writer, PlatformDo
      * Reads cache configuration from a stream.
      *
      * @param in Stream.
-     * @param ver Client version.
+     * @param protocolContext Client protocol version.
      * @return Cache configuration.
      */
-    public static CacheConfiguration readCacheConfiguration(BinaryRawReaderEx in, ClientListenerProtocolVersion ver) {
+    public static CacheConfiguration readCacheConfiguration(BinaryRawReaderEx in, ClientProtocolContext protocolContext) {
 
 Review comment:
   As far as I understand, the protocol version was introduced to this method and almost all other methods in this class (except "query entity" methods) by mistake. It's effectively no-op for platform thick clients. I propose to remove redundant parameter from these methods instead of changing its type. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services