[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #16923: Add authority configuration in server.yaml

[GitBox <gi...@apache.org>]

RaigorJiang commented on code in PR #16923:
URL: https://github.com/apache/shardingsphere/pull/16923#discussion_r854739498


##########
shardingsphere-kernel/shardingsphere-authority/shardingsphere-authority-core/src/main/java/org/apache/shardingsphere/authority/yaml/config/YamlAuthorityConfiguration.java:
##########
@@ -51,8 +51,8 @@ public Class<AuthorityRuleConfiguration> getRuleConfigurationType() {
     }
     
     /**
-     *  Convert to yaml authority rule configuration.
-     *  TODO YamlAuthorityRuleConfiguration will be removed later
+     * Convert to yaml authority rule configuration.
+     *
      * @return yaml authority rule configuration
      */
     public YamlAuthorityRuleConfiguration convertYamlAuthorityRuleConfiguration() {

Review Comment:
   `convertToXX `  may better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org