You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2008/12/03 02:04:44 UTC

[jira] Created: (HIVE-103) inserts allowed in subqueries by the parser

inserts allowed in subqueries by the parser
-------------------------------------------

                 Key: HIVE-103
                 URL: https://issues.apache.org/jira/browse/HIVE-103
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Build Infrastructure
            Reporter: Namit Jain
            Assignee: Namit Jain


SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y

parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654672#action_12654672 ] 

Namit Jain commented on HIVE-103:
---------------------------------

There is no check currently. The above query actually succeeds

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-103:
----------------------------

    Attachment: patch103.txt

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-103:
----------------------------

    Status: Open  (was: Patch Available)

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654919#action_12654919 ] 

Raghotham Murthy commented on HIVE-103:
---------------------------------------

+1

looks good.

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-103:
--------------------------------

    Fix Version/s: 0.3.0

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.3.0
>
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-103:
----------------------------

    Attachment: patch103.1.txt

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653456#action_12653456 ] 

Zheng Shao commented on HIVE-103:
---------------------------------

One good thing about doing the check in compiler is that it's easier to output some meaningful error message to the user.

The parser's error message probably won't be easy to understand, for this case.


> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-103:
----------------------------

    Attachment: patch103.txt

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652643#action_12652643 ] 

Zheng Shao commented on HIVE-103:
---------------------------------

I guess you mean that Parser needs to distinguish queries that produce results and those that does not? Like functions with or without returning values?

how do you compare that with doing the check in the compiler step?


> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-103:
----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

HIVE-103. Disable inserts in sub queries. (Namit Jain through zshao)

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-103:
----------------------------

    Status: Patch Available  (was: Open)

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Hammerbacher updated HIVE-103:
-----------------------------------

    Component/s:     (was: Build Infrastructure)
                 Query Processor

Changed component from "Build Infrastructure" to "Query Processor"

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654999#action_12654999 ] 

Zheng Shao commented on HIVE-103:
---------------------------------

Committed revision 724923.

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-103:
----------------------------

    Status: Patch Available  (was: Open)

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-103) inserts allowed in subqueries by the parser

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654915#action_12654915 ] 

Namit Jain commented on HIVE-103:
---------------------------------

changed error message on raghu's suggestion

> inserts allowed in subqueries by the parser
> -------------------------------------------
>
>                 Key: HIVE-103
>                 URL: https://issues.apache.org/jira/browse/HIVE-103
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: patch103.1.txt, patch103.txt, patch103.txt
>
>
> SELECT * FROM (INSERT OVERWRITE  TABLE T1  SELECT * FROM  A ) y
> parses successfully. Parser needs to distinguish between top level and sub queries and act accordingly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.