[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5559: [Refactor] make uint24_t,OLAPIndexFixedHeader as a POD type

[GitBox <gi...@apache.org>]

yangzhg commented on a change in pull request #5559:
URL: https://github.com/apache/incubator-doris/pull/5559#discussion_r600357835



##########
File path: be/src/util/coding.h
##########
@@ -171,14 +171,14 @@ extern const uint8_t* decode_varint64_ptr(const uint8_t* p, const uint8_t* limit
 
 template <typename T>
 inline void put_varint32(T* dst, uint32_t v) {
-    uint8_t buf[5];
+    uint8_t buf[16];

Review comment:
       #pragma GCC diagnostic ignored "-Warray-bounds" is better




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org