You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ts...@apache.org on 2013/10/02 18:41:37 UTC

[07/50] [abbrv] git commit: updated refs/heads/marvin-refactor to bbaf354

marvin_refactor: getText() reveals the actual value

otherwise required is always not None and always True

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/1a6006c1
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/1a6006c1
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/1a6006c1

Branch: refs/heads/marvin-refactor
Commit: 1a6006c14653dccfe32ac94a1d87b45a3a693fa0
Parents: a81600b
Author: Prasanna Santhanam <ts...@apache.org>
Authored: Wed Sep 4 13:11:05 2013 +0530
Committer: Prasanna Santhanam <ts...@apache.org>
Committed: Wed Oct 2 20:27:16 2013 +0530

----------------------------------------------------------------------
 tools/marvin/marvin/codegenerator.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/1a6006c1/tools/marvin/marvin/codegenerator.py
----------------------------------------------------------------------
diff --git a/tools/marvin/marvin/codegenerator.py b/tools/marvin/marvin/codegenerator.py
index cb0cb5c..28ec4dd 100644
--- a/tools/marvin/marvin/codegenerator.py
+++ b/tools/marvin/marvin/codegenerator.py
@@ -311,7 +311,7 @@ class codeGenerator(object):
                 assert paramProperty.name
 
                 required = param.getElementsByTagName('required')
-                if required:
+                if getText(required) == "true":
                     paramProperty.required = getText(required)
 
                 requestDescription = param.getElementsByTagName('description')