You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/02/09 11:05:34 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16580: [refactor](remove unused code) remove load stream mgr
github-actions[bot] commented on code in PR #16580:
URL: https://github.com/apache/doris/pull/16580#discussion_r1101306551
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -344,7 +343,6 @@
k_add_batch_status = Status::OK();
_env = ExecEnv::GetInstance();
_env->_master_info = new TMasterInfo();
- _env->_load_stream_mgr = new LoadStreamMgr();
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
Review Comment:
warning: '_internal_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
^
```
**be/src/runtime/exec_env.h:231:** declared private here
```cpp
BrpcClientCache<PBackendService_Stub>* _internal_client_cache = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -344,7 +343,6 @@
k_add_batch_status = Status::OK();
_env = ExecEnv::GetInstance();
_env->_master_info = new TMasterInfo();
- _env->_load_stream_mgr = new LoadStreamMgr();
_env->_internal_client_cache = new BrpcClientCache<PBackendService_Stub>();
_env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
Review Comment:
warning: '_function_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_env->_function_client_cache = new BrpcClientCache<PFunctionService_Stub>();
^
```
**be/src/runtime/exec_env.h:232:** declared private here
```cpp
BrpcClientCache<PFunctionService_Stub>* _function_client_cache = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -359,7 +357,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
Review Comment:
warning: '_internal_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_internal_client_cache);
^
```
**be/src/runtime/exec_env.h:231:** declared private here
```cpp
BrpcClientCache<PBackendService_Stub>* _internal_client_cache = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -359,7 +357,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_function_client_cache);
- SAFE_DELETE(_env->_load_stream_mgr);
SAFE_DELETE(_env->_master_info);
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_master_info);
^
```
**be/src/runtime/exec_env.h:223:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -359,7 +357,6 @@
void TearDown() override {
SAFE_DELETE(_env->_internal_client_cache);
SAFE_DELETE(_env->_function_client_cache);
Review Comment:
warning: '_function_client_cache' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
SAFE_DELETE(_env->_function_client_cache);
^
```
**be/src/runtime/exec_env.h:232:** declared private here
```cpp
BrpcClientCache<PFunctionService_Stub>* _function_client_cache = nullptr;
^
```
##########
be/test/vec/exec/vtablet_sink_test.cpp:
##########
@@ -344,7 +343,6 @@ class VOlapTableSinkTest : public testing::Test {
k_add_batch_status = Status::OK();
_env = ExecEnv::GetInstance();
_env->_master_info = new TMasterInfo();
Review Comment:
warning: '_master_info' is a private member of 'doris::ExecEnv' [clang-diagnostic-error]
```cpp
_env->_master_info = new TMasterInfo();
^
```
**be/src/runtime/exec_env.h:223:** declared private here
```cpp
TMasterInfo* _master_info = nullptr;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org