You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2013/08/06 23:19:33 UTC
git commit: Disable timed temporary signed URLs for AWS-S3
Updated Branches:
refs/heads/master 435103eb3 -> bc0abbaa0
Disable timed temporary signed URLs for AWS-S3
This functionality uncovered subtleties in URL parameter encoding
which result in random failures integration tests. References
JCLOUDS-200.
Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/commit/bc0abbaa
Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/tree/bc0abbaa
Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/diff/bc0abbaa
Branch: refs/heads/master
Commit: bc0abbaa073a9178f3aeb0d1541ea5fc50dded35
Parents: 435103e
Author: Andrew Gaul <ga...@apache.org>
Authored: Tue Aug 6 14:15:02 2013 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Tue Aug 6 14:17:00 2013 -0700
----------------------------------------------------------------------
.../org/jclouds/aws/s3/blobstore/AWSS3BlobRequestSigner.java | 7 ++-----
.../jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java | 4 ++--
2 files changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/bc0abbaa/providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/AWSS3BlobRequestSigner.java
----------------------------------------------------------------------
diff --git a/providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/AWSS3BlobRequestSigner.java b/providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/AWSS3BlobRequestSigner.java
index dc33ec2..02d1b38 100644
--- a/providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/AWSS3BlobRequestSigner.java
+++ b/providers/aws-s3/src/main/java/org/jclouds/aws/s3/blobstore/AWSS3BlobRequestSigner.java
@@ -72,17 +72,14 @@ public class AWSS3BlobRequestSigner extends S3BlobRequestSigner<AWSS3AsyncClient
public HttpRequest signGetBlob(String container, String name, long timeInSeconds) {
checkNotNull(container, "container");
checkNotNull(name, "name");
- HttpRequest request = processor.apply(Invocation.create(getMethod, ImmutableList.<Object> of(container, name)));
- return cleanRequest(signForTemporaryAccess(request, timeInSeconds));
+ throw new UnsupportedOperationException();
}
@Override
public HttpRequest signPutBlob(String container, Blob blob, long timeInSeconds) {
checkNotNull(container, "container");
checkNotNull(blob, "blob");
- HttpRequest request = processor.apply(Invocation.create(createMethod,
- ImmutableList.<Object>of(container, blobToObject.apply(blob))));
- return cleanRequest(signForTemporaryAccess(request, timeInSeconds));
+ throw new UnsupportedOperationException();
}
private HttpRequest signForTemporaryAccess(HttpRequest request, long timeInSeconds) {
http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/bc0abbaa/providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java
----------------------------------------------------------------------
diff --git a/providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java b/providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java
index 0b38b0b..eb27888 100644
--- a/providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java
+++ b/providers/aws-s3/src/test/java/org/jclouds/aws/s3/blobstore/AWSS3BlobSignerExpectTest.java
@@ -50,7 +50,7 @@ public class AWSS3BlobSignerExpectTest extends S3BlobSignerExpectTest {
.addHeader("Date", DATE).build();
}
- @Test
+ @Test(expectedExceptions = UnsupportedOperationException.class)
public void testSignGetBlobWithTime() {
BlobStore getBlobWithTime = requestsSendResponses(init());
HttpRequest compare = getBlobWithTime();
@@ -68,7 +68,7 @@ public class AWSS3BlobSignerExpectTest extends S3BlobSignerExpectTest {
.addHeader("Date", DATE).build();
}
- @Test
+ @Test(expectedExceptions = UnsupportedOperationException.class)
public void testSignPutBlobWithTime() throws Exception {
BlobStore signPutBloblWithTime = requestsSendResponses(init());
Blob blob = signPutBloblWithTime.blobBuilder(name).payload(text).contentType("text/plain").build();