You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by Willyham <gi...@git.apache.org> on 2015/03/20 23:30:54 UTC

[GitHub] thrift pull request: [THRIFT-3048] - Make TCompactProtocol always ...

GitHub user Willyham opened a pull request:

    https://github.com/apache/thrift/pull/403

    [THRIFT-3048] - Make TCompactProtocol always return an object for i64

    This changes the TCompactProtocol to always return an Int64 object in the same way that TBinary and TJSON do.
    
    This is definitely a breaking change and will likely cause application problems for many people using TCompact and i64 types.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Willyham/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/403.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #403
    
----
commit 11d0a661985cabe63c1dc1b47576bb2b2d6c2e54
Author: Willyham <wi...@uber.com>
Date:   2015-03-20T22:28:01Z

    Make TCompactProtocol always return an object for i64

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: [THRIFT-3048] - Make TCompactProtocol always ...

Posted by Willyham <gi...@git.apache.org>.

Github user Willyham commented on the pull request:

    https://github.com/apache/thrift/pull/403#issuecomment-84170188
  
    Same test cases from the issue run against this code:
    ```
    compact small: 123, object
    binary small: 456, object
    compact: 4294967297, object
    binary: 4294967297, object
    compact large: Infinity, object
    binary large: Infinity, object
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: [THRIFT-3048] - Make TCompactProtocol always ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/403


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] thrift pull request: [THRIFT-3048] - Make TCompactProtocol always ...

Posted by Randy Abernethy <ra...@gmail.com>.

Ya, thanks for the patch!

Hope to have a reference Docker container for build/test soon to make it
easier for contribs to add value. Getting a build going from scratch can be
quite a challenge at present.

On Thu, Mar 26, 2015 at 4:16 PM, Willyham <gi...@git.apache.org> wrote:

> Github user Willyham commented on the pull request:
>
>     https://github.com/apache/thrift/pull/403#issuecomment-86750849
>
>     Hey Randy,
>
>     Thank you. I was having trouble building the entire test suite on my
> distro. I should note that the NodeJS specific tests which run with `npm
> test` all passed after I patched them, so there must be some missing
> coverage in those. Thanks for finishing this up.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] thrift pull request: [THRIFT-3048] - Make TCompactProtocol always ...

Posted by Willyham <gi...@git.apache.org>.

Github user Willyham commented on the pull request:

    https://github.com/apache/thrift/pull/403#issuecomment-86750849
  
    Hey Randy,
    
    Thank you. I was having trouble building the entire test suite on my distro. I should note that the NodeJS specific tests which run with `npm test` all passed after I patched them, so there must be some missing coverage in those. Thanks for finishing this up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---