You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nvazquez <gi...@git.apache.org> on 2017/01/13 14:06:20 UTC
[GitHub] cloudstack pull request #1905: CLOUDSTACK-9738: Optimize vm expunge process ...
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1905
CLOUDSTACK-9738: Optimize vm expunge process for instances with vm snapshots
## Description
It was noticed that expunging instances with many vm snapshots took a look of time, as hypervisor received as many tasks as vm snapshots instance had, apart from the delete vm task. We propose a way to optimize this process for instances with vm snapshots by sending only one delete task to hypervisor, which will delete vm and its snapshots
## Use cases
1. deleteVMsnapohsot-> no changes to current behavior
2. destroyVM with expunge=false -> no actions to VMsnaphsot is performed at the moment. When VM cleanup thread is executed it will perform the same sequence as (3). If instance is recovered before expunged by the cleanup thread it will remain intact with VMSnapshot chain present
3. destroyVM with expunge=true:
* Vmsnaphsot is marked with removed timestamp and state = Expunging in DB
* VM is deleted in HW
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nvazquez/cloudstack expungeVmRefactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1905.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1905
----
commit f5bebb172c36710a3c795a0df542fe443c71a2c9
Author: nvazquez <ni...@gmail.com>
Date: 2017-01-09T20:08:32Z
CLOUDSTACK-9738: Optimize vm expunge process for instances with vm snapshots
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1905
There are some conflicts after the latest merge. Can you resolve them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi regarding tests done, we've compared the number of delete tasks sent to Vmware hypervisor on expunging a vm with `N` vm snapshots before and after this optimization, reducing from `N+1` tasks to only `1`. Is a marvin test required for this case?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by ozhanrk <gi...@git.apache.org>.
Github user ozhanrk commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi @nvazquez;
You are right i am referring to volume based snapshots.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by serg38 <gi...@git.apache.org>.
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@rhtyd @karuturi Can we run tests on this PR and merge on success ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi @ozhanrk,
In this PR, vm snapshots get deleted when the instance gets deleted from hypervisor, on task sent by the vm cleanup thread. Can it be possible that you were referring to volume snapshots instead of vm snapshots for restoring vms?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi @nvazquez
Did the behavior in step2 change with this PR or is it same as earlier?
Can you please add the testing already done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Thanks for the clarification. Its a nice enhancement. LGTM for the changes.
Marvin tests are always welcome :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1905
<b>Trillian test result (tid-800)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32817 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1905-t800-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 864.15 | test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 366.16 | test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.30 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.11 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 240.86 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 262.05 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 504.83 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 506.66 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1416.61 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 553.45 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1281.45 | test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.54 | test_volumes.py
test_08_resize_volume | Success | 156.48 | test_volumes.py
test_07_resize_fail | Success | 161.54 | test_volumes.py
test_06_download_detached_volume | Success | 156.85 | test_volumes.py
test_05_detach_volume | Success | 155.81 | test_volumes.py
test_04_delete_attached_volume | Success | 151.26 | test_volumes.py
test_03_download_attached_volume | Success | 156.31 | test_volumes.py
test_02_attach_volume | Success | 90.52 | test_volumes.py
test_01_create_volume | Success | 711.41 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.78 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.73 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 277.87 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.71 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.91 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.87 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 126.01 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.19 | test_vm_life_cycle.py
test_01_stop_vm | Success | 45.35 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 45.51 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.08 | test_templates.py
test_04_extract_template | Success | 5.25 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.19 | test_templates.py
test_01_create_template | Success | 45.45 | test_templates.py
test_10_destroy_cpvm | Success | 131.70 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.66 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.78 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.61 | test_ssvm.py
test_06_stop_cpvm | Success | 131.78 | test_ssvm.py
test_05_stop_ssvm | Success | 139.48 | test_ssvm.py
test_04_cpvm_internals | Success | 1.17 | test_ssvm.py
test_03_ssvm_internals | Success | 4.06 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.23 | test_snapshots.py
test_04_change_offering_small | Success | 239.59 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.33 | test_routers.py
test_08_start_router | Success | 30.35 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.72 | test_routers.py
test_03_restart_network_cleanup | Success | 60.55 | test_routers.py
test_02_router_internal_adv | Success | 1.09 | test_routers.py
test_01_router_internal_basic | Success | 0.61 | test_routers.py
test_router_dns_guestipquery | Success | 77.07 | test_router_dns.py
test_router_dns_externalipquery | Success | 0.08 | test_router_dns.py
test_router_dhcphosts | Success | 272.70 | test_router_dhcphosts.py
test_router_dhcp_opts | Success | 21.75 | test_router_dhcphosts.py
test_01_updatevolumedetail | Success | 0.08 | test_resource_detail.py
test_01_reset_vm_on_reboot | Success | 130.92 | test_reset_vm_on_reboot.py
test_createRegion | Success | 0.03 | test_regions.py
test_create_pvlan_network | Success | 5.25 | test_pvlan.py
test_dedicatePublicIpRange | Success | 0.45 | test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup | Success | 501.20 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | Success | 406.36 | test_privategw_acl.py
test_01_vpc_privategw_acl | Success | 92.61 | test_privategw_acl.py
test_01_primary_storage_nfs | Success | 35.81 | test_primary_storage.py
test_createPortablePublicIPRange | Success | 15.19 | test_portable_publicip.py
test_createPortablePublicIPAcquire | Success | 15.45 | test_portable_publicip.py
test_isolate_network_password_server | Success | 89.52 | test_password_server.py
test_UpdateStorageOverProvisioningFactor | Success | 0.13 | test_over_provisioning.py
test_oobm_zchange_password | Success | 30.65 | test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership | Success | 16.34 | test_outofbandmanagement.py
test_oobm_issue_power_status | Success | 10.34 | test_outofbandmanagement.py
test_oobm_issue_power_soft | Success | 15.36 | test_outofbandmanagement.py
test_oobm_issue_power_reset | Success | 15.33 | test_outofbandmanagement.py
test_oobm_issue_power_on | Success | 15.32 | test_outofbandmanagement.py
test_oobm_issue_power_off | Success | 15.33 | test_outofbandmanagement.py
test_oobm_issue_power_cycle | Success | 10.30 | test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones | Success | 92.99 | test_outofbandmanagement.py
test_oobm_enable_feature_valid | Success | 5.16 | test_outofbandmanagement.py
test_oobm_enable_feature_invalid | Success | 0.09 | test_outofbandmanagement.py
test_oobm_disable_feature_valid | Success | 5.17 | test_outofbandmanagement.py
test_oobm_disable_feature_invalid | Success | 0.10 | test_outofbandmanagement.py
test_oobm_configure_invalid_driver | Success | 0.08 | test_outofbandmanagement.py
test_oobm_configure_default_driver | Success | 0.07 | test_outofbandmanagement.py
test_oobm_background_powerstate_sync | Success | 23.42 | test_outofbandmanagement.py
test_extendPhysicalNetworkVlan | Success | 15.44 | test_non_contigiousvlan.py
test_01_nic | Success | 435.03 | test_nic.py
test_releaseIP | Success | 242.84 | test_network.py
test_reboot_router | Success | 418.83 | test_network.py
test_public_ip_user_account | Success | 10.26 | test_network.py
test_public_ip_admin_account | Success | 40.28 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 67.01 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.73 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.37 | test_network.py
test_delete_account | Success | 292.89 | test_network.py
test_02_port_fwd_on_non_src_nat | Success | 55.72 | test_network.py
test_01_port_fwd_on_src_nat | Success | 111.73 | test_network.py
test_nic_secondaryip_add_remove | Success | 202.62 | test_multipleips_per_nic.py
login_test_saml_user | Success | 19.15 | test_login.py
test_assign_and_removal_lb | Success | 133.67 | test_loadbalance.py
test_02_create_lb_rule_non_nat | Success | 187.44 | test_loadbalance.py
test_01_create_lb_rule_src_nat | Success | 218.08 | test_loadbalance.py
test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
test_02_list_templates | Success | 0.04 | test_list_ids_parameter.py
test_01_list_volumes | Success | 0.03 | test_list_ids_parameter.py
test_07_list_default_iso | Success | 0.06 | test_iso.py
test_05_iso_permissions | Success | 0.06 | test_iso.py
test_04_extract_Iso | Success | 5.19 | test_iso.py
test_03_delete_iso | Success | 95.19 | test_iso.py
test_02_edit_iso | Success | 0.06 | test_iso.py
test_01_create_iso | Success | 20.99 | test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 203.69 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 144.17 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 522.59 | test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 425.19 | test_internal_lb.py
test_dedicateGuestVlanRange | Success | 10.26 | test_guest_vlan_range.py
test_UpdateConfigParamWithScope | Success | 0.14 | test_global_settings.py
test_rolepermission_lifecycle_update | Success | 6.14 | test_dynamicroles.py
test_rolepermission_lifecycle_list | Success | 5.96 | test_dynamicroles.py
test_rolepermission_lifecycle_delete | Success | 5.86 | test_dynamicroles.py
test_rolepermission_lifecycle_create | Success | 5.90 | test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates | Success | 6.01 | test_dynamicroles.py
test_role_lifecycle_update_role_inuse | Success | 5.89 | test_dynamicroles.py
test_role_lifecycle_update | Success | 11.14 | test_dynamicroles.py
test_role_lifecycle_list | Success | 5.89 | test_dynamicroles.py
test_role_lifecycle_delete | Success | 10.94 | test_dynamicroles.py
test_role_lifecycle_create | Success | 5.89 | test_dynamicroles.py
test_role_inuse_deletion | Success | 5.88 | test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers | Success | 8.23 | test_dynamicroles.py
test_role_account_acls | Success | 8.21 | test_dynamicroles.py
test_default_role_deletion | Success | 5.98 | test_dynamicroles.py
test_04_create_fat_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_03_delete_disk_offering | Success | 0.04 | test_disk_offerings.py
test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
test_02_create_sparse_type_disk_offering | Success | 0.07 | test_disk_offerings.py
test_01_create_disk_offering | Success | 0.11 | test_disk_offerings.py
test_deployvm_userdispersing | Success | 20.59 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated | Success | 35.70 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit | Success | 55.66 | test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post | Success | 10.40 | test_deploy_vm_with_userdata.py
test_deployvm_userdata | Success | 55.75 | test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize | Success | 6.04 | test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize | Success | 6.07 | test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize | Success | 207.73 | test_deploy_vm_root_resize.py
test_deploy_vm_from_iso | Success | 207.48 | test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup | Success | 65.96 | test_affinity_groups.py
test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
test_06_copy_template | Skipped | 0.00 | test_templates.py
test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
test_11_ss_nfs_version_on_ssvm | Skipped | 0.04 | test_ssvm.py
test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py
test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
test_06_copy_iso | Skipped | 0.00 | test_iso.py
test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi sure, done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@karuturi a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by ozhanrk <gi...@git.apache.org>.
Github user ozhanrk commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi, we currently hold vm snapshots like as vm backup, even if we destroy vm with expunge. So that we could restore vm snapshot on future time. Does this pr has any effect on our scenario?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: [Vmware] Optimize vm expunge proces...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
Hi @karuturi,
On Vmware, step 2 reduces tasks sent to hypervisor by sending only one task which actually deletes vm snapshots and the vm itself instead of sending one for each vm snapshot plus the one for the vm. For other hypervisors, it would work the same. I refactored this PR adding tag [Vmware] on title too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...
Posted by nvazquez <gi...@git.apache.org>.
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1905
@ozhanrk nice, then this PR shouldn't affect your workflow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---