You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2011/12/02 14:49:09 UTC
svn commit: r1209477 - in /camel/trunk/camel-core/src:
main/java/org/apache/camel/builder/ main/java/org/apache/camel/model/
test/java/org/apache/camel/language/ test/java/org/apache/camel/util/
Author: davsclaus
Date: Fri Dec 2 13:49:09 2011
New Revision: 1209477
URL: http://svn.apache.org/viewvc?rev=1209477&view=rev
Log:
CAMEL-4733: Fixed issue with Java DSL creating expression with expression clause, not ensuring the model is update with the expression definition being used. This would cause the JAXB model of the route to not contain the actual expression in use.
Added:
camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSetBodyRouteTest.java
camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
Modified:
camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClause.java
camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java
camel/trunk/camel-core/src/main/java/org/apache/camel/model/ExpressionNode.java
camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java
camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java
Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClause.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClause.java?rev=1209477&r1=1209476&r2=1209477&view=diff
==============================================================================
--- camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClause.java (original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClause.java Fri Dec 2 13:49:09 2011
@@ -636,22 +636,6 @@ public class ExpressionClause<T> extends
// Properties
// -------------------------------------------------------------------------
-
- @Override
- public String getLanguage() {
- return delegate.getLanguage();
- }
-
- @Override
- public String getExpression() {
- return delegate.getExpression();
- }
-
- @Override
- public void setExpression(String expression) {
- delegate.setExpression(expression);
- }
-
@Override
public Expression getExpressionValue() {
return delegate.getExpressionValue();
Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java?rev=1209477&r1=1209476&r2=1209477&view=diff
==============================================================================
--- camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java (original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/builder/ExpressionClauseSupport.java Fri Dec 2 13:49:09 2011
@@ -28,6 +28,7 @@ import org.apache.camel.model.language.G
import org.apache.camel.model.language.HeaderExpression;
import org.apache.camel.model.language.JXPathExpression;
import org.apache.camel.model.language.JavaScriptExpression;
+import org.apache.camel.model.language.LanguageExpression;
import org.apache.camel.model.language.MethodCallExpression;
import org.apache.camel.model.language.MvelExpression;
import org.apache.camel.model.language.OgnlExpression;
@@ -42,8 +43,6 @@ import org.apache.camel.model.language.S
import org.apache.camel.model.language.TokenizerExpression;
import org.apache.camel.model.language.XPathExpression;
import org.apache.camel.model.language.XQueryExpression;
-import org.apache.camel.spi.Language;
-import org.apache.camel.util.ObjectHelper;
/**
* A support class for building expression clauses.
@@ -53,8 +52,6 @@ import org.apache.camel.util.ObjectHelpe
public class ExpressionClauseSupport<T> {
private T result;
- private String language;
- private String expression;
private Expression expressionValue;
private ExpressionDefinition expressionType;
@@ -684,28 +681,13 @@ public class ExpressionClauseSupport<T>
* @return the builder to continue processing the DSL
*/
public T language(String language, String expression) {
- setLanguage(language);
- setExpression(expression);
+ LanguageExpression exp = new LanguageExpression(language, expression);
+ setExpressionType(exp);
return result;
}
// Properties
// -------------------------------------------------------------------------
- public String getLanguage() {
- return language;
- }
-
- public void setLanguage(String language) {
- this.language = language;
- }
-
- public String getExpression() {
- return expression;
- }
-
- public void setExpression(String expression) {
- this.expression = expression;
- }
public Expression getExpressionValue() {
return expressionValue;
@@ -727,11 +709,8 @@ public class ExpressionClauseSupport<T>
if (getExpressionValue() == null) {
if (getExpressionType() != null) {
setExpressionValue(getExpressionType().createExpression(camelContext));
- } else if (getExpression() != null) {
- ObjectHelper.notNull("language", getLanguage());
- Language language = camelContext.resolveLanguage(getLanguage());
- setExpressionValue(language.createExpression(getExpression()));
- configureExpression(camelContext, getExpressionValue());
+ } else {
+ throw new IllegalStateException("No expression value configured");
}
}
return getExpressionValue();
Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/model/ExpressionNode.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ExpressionNode.java?rev=1209477&r1=1209476&r2=1209477&view=diff
==============================================================================
--- camel/trunk/camel-core/src/main/java/org/apache/camel/model/ExpressionNode.java (original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/model/ExpressionNode.java Fri Dec 2 13:49:09 2011
@@ -104,8 +104,19 @@ public class ExpressionNode extends Proc
@Override
protected void configureChild(ProcessorDefinition output) {
- if (expression instanceof ExpressionClause) {
- ExpressionClause clause = (ExpressionClause) expression;
+ // reuse the logic from pre create processor
+ preCreateProcessor();
+ }
+
+ @Override
+ protected void preCreateProcessor() {
+ Expression exp = expression;
+ if (expression.getExpressionValue() != null) {
+ exp = expression.getExpressionValue();
+ }
+
+ if (exp instanceof ExpressionClause) {
+ ExpressionClause clause = (ExpressionClause) exp;
if (clause.getExpressionType() != null) {
// if using the Java DSL then the expression may have been set using the
// ExpressionClause which is a fancy builder to define expressions and predicates
@@ -115,5 +126,4 @@ public class ExpressionNode extends Proc
}
}
}
-
}
Modified: camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java?rev=1209477&r1=1209476&r2=1209477&view=diff
==============================================================================
--- camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java (original)
+++ camel/trunk/camel-core/src/main/java/org/apache/camel/model/ProcessorDefinition.java Fri Dec 2 13:49:09 2011
@@ -48,7 +48,6 @@ import org.apache.camel.builder.DataForm
import org.apache.camel.builder.ExpressionBuilder;
import org.apache.camel.builder.ExpressionClause;
import org.apache.camel.builder.ProcessorBuilder;
-import org.apache.camel.component.properties.PropertiesComponent;
import org.apache.camel.model.language.ConstantExpression;
import org.apache.camel.model.language.ExpressionDefinition;
import org.apache.camel.model.language.LanguageExpression;
@@ -425,6 +424,9 @@ public abstract class ProcessorDefinitio
// resolve constant fields (eg Exchange.FILE_NAME)
resolveKnownConstantFields(this);
+ // allow any custom logic before we create the processor
+ preCreateProcessor();
+
// at first use custom factory
if (routeContext.getCamelContext().getProcessorFactory() != null) {
processor = routeContext.getCamelContext().getProcessorFactory().createProcessor(routeContext, this);
@@ -563,6 +565,13 @@ public abstract class ProcessorDefinitio
}
/**
+ * Strategy to execute any custom logic before the {@link Processor} is created.
+ */
+ protected void preCreateProcessor() {
+ // noop
+ }
+
+ /**
* Strategy for children to do any custom configuration
*
* @param output the child to be added as output to this
Modified: camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java?rev=1209477&r1=1209476&r2=1209477&view=diff
==============================================================================
--- camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java (original)
+++ camel/trunk/camel-core/src/test/java/org/apache/camel/language/BeanLanguageInvalidOGNLTest.java Fri Dec 2 13:49:09 2011
@@ -19,9 +19,9 @@ package org.apache.camel.language;
import java.util.LinkedHashMap;
import java.util.Map;
-import org.apache.camel.CamelExecutionException;
import org.apache.camel.ContextTestSupport;
import org.apache.camel.ExpressionIllegalSyntaxException;
+import org.apache.camel.FailedToCreateRouteException;
import org.apache.camel.RuntimeCamelException;
import org.apache.camel.builder.RouteBuilder;
import org.apache.camel.component.bean.MethodNotFoundException;
@@ -32,10 +32,16 @@ import org.apache.camel.component.bean.M
public class BeanLanguageInvalidOGNLTest extends ContextTestSupport {
public void testBeanLanguageInvalidOGNL() throws Exception {
+ context.addRoutes(new RouteBuilder() {
+ @Override
+ public void configure() throws Exception {
+ from("direct:start")
+ .transform().method(MyReallyCoolBean.class, "getOther[xx");
+ }
+ });
try {
- template.requestBody("direct:start", "World", String.class);
- fail("Should have thrown exception");
- } catch (CamelExecutionException e) {
+ context.start();
+ } catch (FailedToCreateRouteException e) {
RuntimeCamelException rce = assertIsInstanceOf(RuntimeCamelException.class, e.getCause());
MethodNotFoundException mnfe = assertIsInstanceOf(MethodNotFoundException.class, rce.getCause());
assertEquals("getOther[xx", mnfe.getMethodName());
@@ -46,14 +52,8 @@ public class BeanLanguageInvalidOGNLTest
}
@Override
- protected RouteBuilder createRouteBuilder() throws Exception {
- return new RouteBuilder() {
- @Override
- public void configure() throws Exception {
- from("direct:start")
- .transform().method(MyReallyCoolBean.class, "getOther[xx");
- }
- };
+ public boolean isUseRouteBuilder() {
+ return false;
}
public static class MyReallyCoolBean {
Added: camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSetBodyRouteTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSetBodyRouteTest.java?rev=1209477&view=auto
==============================================================================
--- camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSetBodyRouteTest.java (added)
+++ camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlSetBodyRouteTest.java Fri Dec 2 13:49:09 2011
@@ -0,0 +1,48 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.util;
+
+import org.apache.camel.ContextTestSupport;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.model.ModelHelper;
+
+/**
+ *
+ */
+public class DumpModelAsXmlSetBodyRouteTest extends ContextTestSupport {
+
+ public void testDumpModelAsXml() throws Exception {
+ String xml = ModelHelper.dumpModelAsXml(context.getRouteDefinition("myRoute"));
+ assertNotNull(xml);
+ log.info(xml);
+
+ // TODO: Fix so we have the expression in the dumped route
+ // assertTrue(xml.contains("<simple>Hello ${body}</simple>"));
+ }
+
+ @Override
+ protected RouteBuilder createRouteBuilder() throws Exception {
+ return new RouteBuilder() {
+ @Override
+ public void configure() throws Exception {
+ from("direct:start").routeId("myRoute")
+ .setBody(simple("Hello ${body}"))
+ .to("mock:result");
+ }
+ };
+ }
+}
Added: camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java
URL: http://svn.apache.org/viewvc/camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java?rev=1209477&view=auto
==============================================================================
--- camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java (added)
+++ camel/trunk/camel-core/src/test/java/org/apache/camel/util/DumpModelAsXmlTransformRouteTest.java Fri Dec 2 13:49:09 2011
@@ -0,0 +1,47 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.util;
+
+import org.apache.camel.ContextTestSupport;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.model.ModelHelper;
+
+/**
+ *
+ */
+public class DumpModelAsXmlTransformRouteTest extends ContextTestSupport {
+
+ public void testDumpModelAsXml() throws Exception {
+ String xml = ModelHelper.dumpModelAsXml(context.getRouteDefinition("myRoute"));
+ assertNotNull(xml);
+ log.info(xml);
+
+ assertTrue(xml.contains("<simple>Hello ${body}</simple>"));
+ }
+
+ @Override
+ protected RouteBuilder createRouteBuilder() throws Exception {
+ return new RouteBuilder() {
+ @Override
+ public void configure() throws Exception {
+ from("direct:start").routeId("myRoute")
+ .transform().simple("Hello ${body}")
+ .to("mock:result");
+ }
+ };
+ }
+}