You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2009/01/06 01:33:44 UTC
[jira] Commented: (SCXML-103) Remove any catch (Throwable t)
occurences
[ https://issues.apache.org/jira/browse/SCXML-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661002#action_12661002 ]
Sebb commented on SCXML-103:
----------------------------
(Re subject change - sorry meant to do it myself!).
Applied to J6
URL: http://svn.apache.org/viewvc?rev=731781&view=rev
Log:
SCXML-103 Remove any catch (Throwable t) occurences:
Catch specific Exceptions/Errors rather than generic ones
and trunk:
URL: http://svn.apache.org/viewvc?rev=731791&view=rev
Log:
SCXML-103 Remove any catch (Throwable t) occurences:
Catch specific Exceptions/Errors rather than generic ones
> Remove any catch (Throwable t) occurences
> -----------------------------------------
>
> Key: SCXML-103
> URL: https://issues.apache.org/jira/browse/SCXML-103
> Project: Commons SCXML
> Issue Type: Bug
> Reporter: Sebb
> Priority: Minor
> Fix For: 0.10, 1.0
>
>
> There are a few instances where the code catches Throwable, but fails to rethrow anything.
> For example:
> {code}
> org.apache.commons.scxml.io.SCXMLSerializer.getTransformer()
> ...
> } catch (Throwable t) {
> return null;
> }
> {code}
> It would be safer if the code only caught the relevant Exception(s) (and perhaps some Errors).
> For example does it really make sense to catch OutOfMemory ?
> In particular, the Javadoc for ThreadDeath says:
> {quote} If ThreadDeath is caught by a method, it is important that it be rethrown so that the thread actually dies.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.