You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/18 17:47:39 UTC

[GitHub] [commons-geometry] singhbaljit commented on a change in pull request #123: Minor Improvement

singhbaljit commented on a change in pull request #123:
URL: https://github.com/apache/commons-geometry/pull/123#discussion_r545989644



##########
File path: commons-geometry-examples/examples-io/src/main/java/org/apache/commons/geometry/examples/io/threed/DefaultModelIOHandlerRegistry.java
##########
@@ -28,8 +29,8 @@
     /** Construct a new instance and register known handlers.
      */
     public DefaultModelIOHandlerRegistry() {
-        setHandlers(Arrays.asList(
+        setHandlers(Collections.singletonList(

Review comment:
       Make it one line?

##########
File path: commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/mesh/SimpleTriangleMeshTest.java
##########
@@ -261,8 +261,8 @@ public void testFaces_iterator() {
             Vector3D.of(0, 1, 0)
         );
 
-        final List<int[]> faceIndices = Arrays.asList(
-            new int[] {0, 1, 2}
+        final List<int[]> faceIndices = Collections.singletonList(

Review comment:
       Make it one line?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org