You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Volodymyr Vysotskyi <vo...@apache.org> on 2019/12/22 17:00:39 UTC
[VOTE] Release Apache Drill 1.17.0 - RC2
Hi all,
I'd like to propose the third release candidate (RC2) of Apache Drill,
version 1.17.0.
Changes since the previous release candidate: fixed show-stopper DRILL-7494
<https://issues.apache.org/jira/browse/DRILL-7494>.
The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
everyone who contributed to this release.
The tarball artifacts are hosted at [2] and the maven artifacts are hosted
at [3].
This release candidate is based on
commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
Please download and try out the release.
The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
2019
[ ] +1
[ ] +0
[ ] -1
Here's my vote: +1
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
[2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
[3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
[4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
Kind regards,
Volodymyr Vysotskyi
Type function fixes
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Thanks much to Igor for listing the bugs associated with the type functions.
A bit of research (listed in DRILL-6362) shows how other engines (such as SqlLite and Postgres) implement the typeof() function. As a result, I've issued a PR [1] with three changes:
* When typeof() is used with the UNION type, it reports the type of the value, not the type of the column. if the value is NULL, then there is no type and typeof() returns "NULL". This is in line with the way Snowflake implements the function. (DRILL-6362).
* When typeof() is used with a column other than UNION, it always returns the type name, even if the column value is null. (DRILL-6362).
* sqlTypeOf() returns the data type for a repeated type instead of "ARRAY". sqlTypeOf() returns "ARRAY" for the LIST type since the LIST type seems to be designed to be a repeated UNION. (DRILL-7499.)
* drillTypeOf() returns the type of column. like typeof(). However, if the column is UNION or DICT, then drillTypeOf() returns the static type (UNION or DICT), not the value type.
As it turns out, we do have comprehensive unit tests for these functions in TestTypeFns.java. The reason that we did not catch the change above was that is is actually hard to set up a query that uses REPEATED, UNION or LIST types -- which are exactly where we had problems. So, I added tests for these cases, and for the UNION type.
As it turned out, when I added the UNION test case, I ran into a nasty codegen bug: DRILL-7502. Basically, this code could never have worked for UNION, but UNION is the type where the typeof() function is most needed. Was able to find a fix.
(As an aside, whoever wrote the expression code generation stuff was wicked smart: that stuff is hugely complex, with many complex cases. Very impressive.)
Thanks,
- Paul
[1] https://github.com/apache/drill/pull/1945
On Friday, December 27, 2019, 2:48:40 AM PST, Igor Guzenko <ih...@gmail.com> wrote:
Hello Paul,
While working on complex types I also was unable to find any document with
expected results of the *typeOf functions.
Since you've implemented them, could you please describe them in some way?
Or it would be even better to extend test coverage in TestTypeFns.java
so nobody could accidentally break the functionality.
Related Jira tickets:
https://issues.apache.org/jira/browse/DRILL-6360
https://issues.apache.org/jira/browse/DRILL-6362
https://issues.apache.org/jira/browse/DRILL-6377
https://issues.apache.org/jira/browse/DRILL-5189
Thanks,
Igor
On Fri, Dec 27, 2019 at 11:18 AM Arina Yelchiyeva <
arina.yelchiyeva@gmail.com> wrote:
> Hi Paul,
>
> thanks for verifying the release.
> Regression for the release is considered something that worked in previous
> version, in our case in 1.16 and stopped working in the released, in our
> case case 1.17. Vova has checked both sqltypeof issues, they behave the
> same in 1.16 so from the release perspective, they are not regressions but
> bugs. Thus they won’t have sinked the last release candidate. By the way,
> one of the issues actually was a deliberate change in 1.16, I have left
> comment in Jira.
>
> Regarding minor release, since both issues are not regressions, there is
> no point of doing it. Though if they were, I would still say we should not
> prepare minor release unless found bugs are something really serious that
> prevents Drill from starting. Mostly because release preparation takes time
> not only for the release manager but for the PMCs and committers to verify
> and cast votes.
>
> Actually, it a good time to think when we want to release 1.18 and find
> volunteer to be a release manager.
>
> Kind regards,
> Arina
>
> > On 27 Dec 2019, at 04:48, Paul Rogers <pa...@yahoo.com.invalid> wrote:
> >
> > Hi Charles,
> >
> > Good question! We have a number of big changes queued up. To do a minor
> release, we'd want to branch off of the Drill 1.17 release, which is extra
> work.
> >
> >
> > Let's see if anyone finds other issues we'd like to fix so we can see if
> the effort would be worthwhile.
> >
> >
> > Thanks,
> > - Paul
> >
> >
> >
> > On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <
> cgivre@gmail.com> wrote:
> >
> > Paul,
> > Do you think it's worth fixing these and releasing a minor release in a
> month or so with this and any other minor bug fixes?
> > -- C
> >
> >> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID>
> wrote:
> >>
> >> Hi All,
> >>
> >> I'm late to the party (was distracted by a certain holiday). Downloaded
> the artifacts and ran though the examples in the first several sections of
> Chapter 8 of the Learning Apache Drill book.
> >>
> >> It turns out we have a regression in the sqlTypeOf() function. See
> DRILL-7499 and DRILL-7501.
> >>
> >> These are minor as they only affect users of the functions. But, the
> errors cause the results in Drill 1.17 to regress from those in Drill 1.14
> (when the book was written.)
> >>
> >> Otherwise, everything seemed to work fine.
> >>
> >> Thanks,
> >> - Paul
> >>
> >>
> >>
> >> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <
> volodymyr@apache.org> wrote:
> >>
> >> Hi all,
> >>
> >> I'd like to propose the third release candidate (RC2) of Apache Drill,
> >> version 1.17.0.
> >>
> >> Changes since the previous release candidate: fixed show-stopper
> DRILL-7494
> >> <https://issues.apache.org/jira/browse/DRILL-7494>.
> >>
> >> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks
> to
> >> everyone who contributed to this release.
> >>
> >> The tarball artifacts are hosted at [2] and the maven artifacts are
> hosted
> >> at [3].
> >>
> >> This release candidate is based on
> >> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
> >>
> >> Please download and try out the release.
> >>
> >> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December
> 25,
> >> 2019
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Here's my vote: +1
> >>
> >> [1]
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> >> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> >> [3]
> https://repository.apache.org/content/repositories/orgapachedrill-1077/
> >> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
> >>
> >> Kind regards,
> >> Volodymyr Vysotskyi
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Hi Igor,
The sqlTypeOf() function came about when we wrote Learning Apache Drill. We wanted a way to show people the actual type of a column, especially in those cases where Drill "makes up" the type, such as when a missing column magically becoming Nullable INT.
The existing "typeOf" function would just return "NULL" in that case, but we could not show the reader what kind of null.
So, we added sqlTypeOf() to return the "minor type" portion of the major type pair for a column. The name returned is supposed to match the SQL names in the Drill documentation. The Drill documentation describes sqlTypeOf() this way: "Returns the data type of a column (using the SQL names) whether the column is NULL or not."
We also added a "modeOf()" function the Mode portion of the MajorType pair. The Drill documentation explains, "Returns the cardinality (mode) of the column as "NOT NULL", "NULLABLE", or "ARRAY". Drill data types include a cardinality, for example Optional Int or Required VarChar."
The result was we could clearly show that a column is, say, a Required Int, Nullable Int or Repeated Int; something the original typeOf() could not do. Chapter 8 of the book uses these two functions in multiple places to explain Drill's type system and schema inference.
Perhaps a better solution would be to have modified the SQL-standard typeof() function to return the fully type name: "INT NOT NULL", "INT" or "ARRAY<INT>". However, we didn't want to break backward compatibility. And, at the time the functions were added (Drill 1.14), the SQL type name syntax was not yet available in Drill.
To follow up on Arina's earlier note: perhaps, now that Drill supports the new type syntax, it makes sense to modify sqlTypeOf() (which is a Drill-specific function) to return the same schema as used in the schema files, using the format shown above.
If we do that, it still makes sense to be able to get at the name and mode separately (so we don't have to parse the full SQL syntax.) So, if sqlTypeOf() returns "ARRAY<INT>", say, then a new sqlNameOf(), could return just "INT".
The functions are likely only used for training and debugging (as noted earlier) so we are probably free to adjust them as the team thinks is best. If anyone was using them in "production" queries, then we would have heard from then when the functionality first changed.
I agree that we should have more complete tests; I'll try to find time to add them.
Actually, this issue raises a larger question. In the "old days", we would create a spec for things like functions. Projects such as Java and Python have language specs that spell out how things are meant to work. Then, if someone changes something in a way that violates the spec, the team knows to have a discussion about the relative merits of that change. (The benefits of the new version vs. the risk of breaking compatibility.) We can't really afford to do that in Drill. So, I like the idea of using unit tests as the next best thing.
Thanks,
- Paul
On Friday, December 27, 2019, 02:48:40 AM PST, Igor Guzenko <ih...@gmail.com> wrote:
Hello Paul,
While working on complex types I also was unable to find any document with
expected results of the *typeOf functions.
Since you've implemented them, could you please describe them in some way?
Or it would be even better to extend test coverage in TestTypeFns.java
so nobody could accidentally break the functionality.
Related Jira tickets:
https://issues.apache.org/jira/browse/DRILL-6360
https://issues.apache.org/jira/browse/DRILL-6362
https://issues.apache.org/jira/browse/DRILL-6377
https://issues.apache.org/jira/browse/DRILL-5189
Thanks,
Igor
On Fri, Dec 27, 2019 at 11:18 AM Arina Yelchiyeva <
arina.yelchiyeva@gmail.com> wrote:
> Hi Paul,
>
> thanks for verifying the release.
> Regression for the release is considered something that worked in previous
> version, in our case in 1.16 and stopped working in the released, in our
> case case 1.17. Vova has checked both sqltypeof issues, they behave the
> same in 1.16 so from the release perspective, they are not regressions but
> bugs. Thus they won’t have sinked the last release candidate. By the way,
> one of the issues actually was a deliberate change in 1.16, I have left
> comment in Jira.
>
> Regarding minor release, since both issues are not regressions, there is
> no point of doing it. Though if they were, I would still say we should not
> prepare minor release unless found bugs are something really serious that
> prevents Drill from starting. Mostly because release preparation takes time
> not only for the release manager but for the PMCs and committers to verify
> and cast votes.
>
> Actually, it a good time to think when we want to release 1.18 and find
> volunteer to be a release manager.
>
> Kind regards,
> Arina
>
> > On 27 Dec 2019, at 04:48, Paul Rogers <pa...@yahoo.com.invalid> wrote:
> >
> > Hi Charles,
> >
> > Good question! We have a number of big changes queued up. To do a minor
> release, we'd want to branch off of the Drill 1.17 release, which is extra
> work.
> >
> >
> > Let's see if anyone finds other issues we'd like to fix so we can see if
> the effort would be worthwhile.
> >
> >
> > Thanks,
> > - Paul
> >
> >
> >
> > On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <
> cgivre@gmail.com> wrote:
> >
> > Paul,
> > Do you think it's worth fixing these and releasing a minor release in a
> month or so with this and any other minor bug fixes?
> > -- C
> >
> >> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID>
> wrote:
> >>
> >> Hi All,
> >>
> >> I'm late to the party (was distracted by a certain holiday). Downloaded
> the artifacts and ran though the examples in the first several sections of
> Chapter 8 of the Learning Apache Drill book.
> >>
> >> It turns out we have a regression in the sqlTypeOf() function. See
> DRILL-7499 and DRILL-7501.
> >>
> >> These are minor as they only affect users of the functions. But, the
> errors cause the results in Drill 1.17 to regress from those in Drill 1.14
> (when the book was written.)
> >>
> >> Otherwise, everything seemed to work fine.
> >>
> >> Thanks,
> >> - Paul
> >>
> >>
> >>
> >> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <
> volodymyr@apache.org> wrote:
> >>
> >> Hi all,
> >>
> >> I'd like to propose the third release candidate (RC2) of Apache Drill,
> >> version 1.17.0.
> >>
> >> Changes since the previous release candidate: fixed show-stopper
> DRILL-7494
> >> <https://issues.apache.org/jira/browse/DRILL-7494>.
> >>
> >> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks
> to
> >> everyone who contributed to this release.
> >>
> >> The tarball artifacts are hosted at [2] and the maven artifacts are
> hosted
> >> at [3].
> >>
> >> This release candidate is based on
> >> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
> >>
> >> Please download and try out the release.
> >>
> >> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December
> 25,
> >> 2019
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Here's my vote: +1
> >>
> >> [1]
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> >> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> >> [3]
> https://repository.apache.org/content/repositories/orgapachedrill-1077/
> >> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
> >>
> >> Kind regards,
> >> Volodymyr Vysotskyi
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Igor Guzenko <ih...@gmail.com>.
Hello Paul,
While working on complex types I also was unable to find any document with
expected results of the *typeOf functions.
Since you've implemented them, could you please describe them in some way?
Or it would be even better to extend test coverage in TestTypeFns.java
so nobody could accidentally break the functionality.
Related Jira tickets:
https://issues.apache.org/jira/browse/DRILL-6360
https://issues.apache.org/jira/browse/DRILL-6362
https://issues.apache.org/jira/browse/DRILL-6377
https://issues.apache.org/jira/browse/DRILL-5189
Thanks,
Igor
On Fri, Dec 27, 2019 at 11:18 AM Arina Yelchiyeva <
arina.yelchiyeva@gmail.com> wrote:
> Hi Paul,
>
> thanks for verifying the release.
> Regression for the release is considered something that worked in previous
> version, in our case in 1.16 and stopped working in the released, in our
> case case 1.17. Vova has checked both sqltypeof issues, they behave the
> same in 1.16 so from the release perspective, they are not regressions but
> bugs. Thus they won’t have sinked the last release candidate. By the way,
> one of the issues actually was a deliberate change in 1.16, I have left
> comment in Jira.
>
> Regarding minor release, since both issues are not regressions, there is
> no point of doing it. Though if they were, I would still say we should not
> prepare minor release unless found bugs are something really serious that
> prevents Drill from starting. Mostly because release preparation takes time
> not only for the release manager but for the PMCs and committers to verify
> and cast votes.
>
> Actually, it a good time to think when we want to release 1.18 and find
> volunteer to be a release manager.
>
> Kind regards,
> Arina
>
> > On 27 Dec 2019, at 04:48, Paul Rogers <pa...@yahoo.com.invalid> wrote:
> >
> > Hi Charles,
> >
> > Good question! We have a number of big changes queued up. To do a minor
> release, we'd want to branch off of the Drill 1.17 release, which is extra
> work.
> >
> >
> > Let's see if anyone finds other issues we'd like to fix so we can see if
> the effort would be worthwhile.
> >
> >
> > Thanks,
> > - Paul
> >
> >
> >
> > On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <
> cgivre@gmail.com> wrote:
> >
> > Paul,
> > Do you think it's worth fixing these and releasing a minor release in a
> month or so with this and any other minor bug fixes?
> > -- C
> >
> >> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID>
> wrote:
> >>
> >> Hi All,
> >>
> >> I'm late to the party (was distracted by a certain holiday). Downloaded
> the artifacts and ran though the examples in the first several sections of
> Chapter 8 of the Learning Apache Drill book.
> >>
> >> It turns out we have a regression in the sqlTypeOf() function. See
> DRILL-7499 and DRILL-7501.
> >>
> >> These are minor as they only affect users of the functions. But, the
> errors cause the results in Drill 1.17 to regress from those in Drill 1.14
> (when the book was written.)
> >>
> >> Otherwise, everything seemed to work fine.
> >>
> >> Thanks,
> >> - Paul
> >>
> >>
> >>
> >> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <
> volodymyr@apache.org> wrote:
> >>
> >> Hi all,
> >>
> >> I'd like to propose the third release candidate (RC2) of Apache Drill,
> >> version 1.17.0.
> >>
> >> Changes since the previous release candidate: fixed show-stopper
> DRILL-7494
> >> <https://issues.apache.org/jira/browse/DRILL-7494>.
> >>
> >> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks
> to
> >> everyone who contributed to this release.
> >>
> >> The tarball artifacts are hosted at [2] and the maven artifacts are
> hosted
> >> at [3].
> >>
> >> This release candidate is based on
> >> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
> >>
> >> Please download and try out the release.
> >>
> >> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December
> 25,
> >> 2019
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Here's my vote: +1
> >>
> >> [1]
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> >> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> >> [3]
> https://repository.apache.org/content/repositories/orgapachedrill-1077/
> >> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
> >>
> >> Kind regards,
> >> Volodymyr Vysotskyi
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Hi all,
Since the release is finished, the master branch is opened for new commits.
Kind regards,
Volodymyr Vysotskyi
On Sat, Dec 28, 2019 at 10:56 AM Paul Rogers <pa...@yahoo.com.invalid>
wrote:
> Hi Arina,
>
> Thanks much to everyone who helped with the release; it is quite a bit of
> work. Coordinating on doing the release builds sounds like a good plan. A
> huge THANK YOU to Vova for gathering the release instructions!
>
> Thanks,
> - Paul
>
>
>
> On Friday, December 27, 2019, 11:06:44 PM PST, Arina Yelchiyeva <
> arina.yelchiyeva@gmail.com> wrote:
>
> If release manager does not have access to the test cluster to run all
> tests, before starting the release he can ask, those who have, to run tests
> on the commit on which release candidate will be prepared. Other than that,
> all the remaining steps does not require any special environment setup.
> Vova is going to add release instruction and scripts to the Drill project
> soon.
>
> Kind regards,
> Arina
>
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Hi all,
Since the release is finished, the master branch is opened for new commits.
Kind regards,
Volodymyr Vysotskyi
On Sat, Dec 28, 2019 at 10:56 AM Paul Rogers <pa...@yahoo.com.invalid>
wrote:
> Hi Arina,
>
> Thanks much to everyone who helped with the release; it is quite a bit of
> work. Coordinating on doing the release builds sounds like a good plan. A
> huge THANK YOU to Vova for gathering the release instructions!
>
> Thanks,
> - Paul
>
>
>
> On Friday, December 27, 2019, 11:06:44 PM PST, Arina Yelchiyeva <
> arina.yelchiyeva@gmail.com> wrote:
>
> If release manager does not have access to the test cluster to run all
> tests, before starting the release he can ask, those who have, to run tests
> on the commit on which release candidate will be prepared. Other than that,
> all the remaining steps does not require any special environment setup.
> Vova is going to add release instruction and scripts to the Drill project
> soon.
>
> Kind regards,
> Arina
>
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Hi Arina,
Thanks much to everyone who helped with the release; it is quite a bit of work. Coordinating on doing the release builds sounds like a good plan. A huge THANK YOU to Vova for gathering the release instructions!
Thanks,
- Paul
On Friday, December 27, 2019, 11:06:44 PM PST, Arina Yelchiyeva <ar...@gmail.com> wrote:
If release manager does not have access to the test cluster to run all tests, before starting the release he can ask, those who have, to run tests on the commit on which release candidate will be prepared. Other than that, all the remaining steps does not require any special environment setup. Vova is going to add release instruction and scripts to the Drill project soon.
Kind regards,
Arina
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Arina Yelchiyeva <ar...@gmail.com>.
If release manager does not have access to the test cluster to run all tests, before starting the release he can ask, those who have, to run tests on the commit on which release candidate will be prepared. Other than that, all the remaining steps does not require any special environment setup. Vova is going to add release instruction and scripts to the Drill project soon.
Kind regards,
Arina
> On 27 Dec 2019, at 22:02, Paul Rogers <pa...@yahoo.com.invalid> wrote:
>
> Hi Arina,
> Thanks for the note.
> I would expand the definition of regression that it worked in one release, and changed in a later release. The problem is, we just didn't check in the Drill 1.16 release. Or, we made the change without understanding the impact.
> In this one area, the entire purpose of the sqlTypeOf() function was to return the name of the type. The existing typeof() did not do so in some cases, which is why we added sqlTypeOf().
> Of course, if there is a good reason for sqlTypeOf() to not return the type name, then I guess I'll need to add a "realSqlTypeOf()"to do what sqlTypeOf() was supposed to do.
> Having worked in commercial software a long time, I would not suggest doing minor release for this issue. It really only affects debugging and training, not production users.
> Thanks for pointing out the release manager issue. Our #1 obstacle to that job is that only CV folks have access to the functional test platform; there is no way for someone like Charles or I to perform the crucial verification step. I think we could do most of the other tasks.
> Thanks,
> - Paul
>
>
>
> On Friday, December 27, 2019, 01:18:48 AM PST, Arina Yelchiyeva <ar...@gmail.com> wrote:
>
> Hi Paul,
>
> thanks for verifying the release.
> Regression for the release is considered something that worked in previous version, in our case in 1.16 and stopped working in the released, in our case case 1.17. Vova has checked both sqltypeof issues, they behave the same in 1.16 so from the release perspective, they are not regressions but bugs. Thus they won’t have sinked the last release candidate. By the way, one of the issues actually was a deliberate change in 1.16, I have left comment in Jira.
>
> Regarding minor release, since both issues are not regressions, there is no point of doing it. Though if they were, I would still say we should not prepare minor release unless found bugs are something really serious that prevents Drill from starting. Mostly because release preparation takes time not only for the release manager but for the PMCs and committers to verify and cast votes.
>
> Actually, it a good time to think when we want to release 1.18 and find volunteer to be a release manager.
>
> Kind regards,
> Arina
>
>> On 27 Dec 2019, at 04:48, Paul Rogers <pa...@yahoo.com.invalid> wrote:
>>
>> Hi Charles,
>>
>> Good question! We have a number of big changes queued up. To do a minor release, we'd want to branch off of the Drill 1.17 release, which is extra work.
>>
>>
>> Let's see if anyone finds other issues we'd like to fix so we can see if the effort would be worthwhile.
>>
>>
>> Thanks,
>> - Paul
>>
>>
>>
>> On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <cg...@gmail.com> wrote:
>>
>> Paul,
>> Do you think it's worth fixing these and releasing a minor release in a month or so with this and any other minor bug fixes?
>> -- C
>>
>>>> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID> wrote:
>>>
>>> Hi All,
>>>
>>> I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
>>>
>>> It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
>>>
>>> These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
>>>
>>> Otherwise, everything seemed to work fine.
>>>
>>> Thanks,
>>> - Paul
>>>
>>>
>>>
>>>> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>>>
>>> Hi all,
>>>
>>> I'd like to propose the third release candidate (RC2) of Apache Drill,
>>> version 1.17.0.
>>>
>>> Changes since the previous release candidate: fixed show-stopper DRILL-7494
>>> <https://issues.apache.org/jira/browse/DRILL-7494>.
>>>
>>> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
>>> everyone who contributed to this release.
>>>
>>> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
>>> at [3].
>>>
>>> This release candidate is based on
>>> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>>>
>>> Please download and try out the release.
>>>
>>> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
>>> 2019
>>>
>>> [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>> Here's my vote: +1
>>>
>>> [1]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
>>> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
>>> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
>>> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>>>
>>> Kind regards,
>>> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Hi Arina,
Thanks for the note.
I would expand the definition of regression that it worked in one release, and changed in a later release. The problem is, we just didn't check in the Drill 1.16 release. Or, we made the change without understanding the impact.
In this one area, the entire purpose of the sqlTypeOf() function was to return the name of the type. The existing typeof() did not do so in some cases, which is why we added sqlTypeOf().
Of course, if there is a good reason for sqlTypeOf() to not return the type name, then I guess I'll need to add a "realSqlTypeOf()"to do what sqlTypeOf() was supposed to do.
Having worked in commercial software a long time, I would not suggest doing minor release for this issue. It really only affects debugging and training, not production users.
Thanks for pointing out the release manager issue. Our #1 obstacle to that job is that only CV folks have access to the functional test platform; there is no way for someone like Charles or I to perform the crucial verification step. I think we could do most of the other tasks.
Thanks,
- Paul
On Friday, December 27, 2019, 01:18:48 AM PST, Arina Yelchiyeva <ar...@gmail.com> wrote:
Hi Paul,
thanks for verifying the release.
Regression for the release is considered something that worked in previous version, in our case in 1.16 and stopped working in the released, in our case case 1.17. Vova has checked both sqltypeof issues, they behave the same in 1.16 so from the release perspective, they are not regressions but bugs. Thus they won’t have sinked the last release candidate. By the way, one of the issues actually was a deliberate change in 1.16, I have left comment in Jira.
Regarding minor release, since both issues are not regressions, there is no point of doing it. Though if they were, I would still say we should not prepare minor release unless found bugs are something really serious that prevents Drill from starting. Mostly because release preparation takes time not only for the release manager but for the PMCs and committers to verify and cast votes.
Actually, it a good time to think when we want to release 1.18 and find volunteer to be a release manager.
Kind regards,
Arina
> On 27 Dec 2019, at 04:48, Paul Rogers <pa...@yahoo.com.invalid> wrote:
>
> Hi Charles,
>
> Good question! We have a number of big changes queued up. To do a minor release, we'd want to branch off of the Drill 1.17 release, which is extra work.
>
>
> Let's see if anyone finds other issues we'd like to fix so we can see if the effort would be worthwhile.
>
>
> Thanks,
> - Paul
>
>
>
> On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <cg...@gmail.com> wrote:
>
> Paul,
> Do you think it's worth fixing these and releasing a minor release in a month or so with this and any other minor bug fixes?
> -- C
>
>> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID> wrote:
>>
>> Hi All,
>>
>> I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
>>
>> It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
>>
>> These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
>>
>> Otherwise, everything seemed to work fine.
>>
>> Thanks,
>> - Paul
>>
>>
>>
>> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>>
>> Hi all,
>>
>> I'd like to propose the third release candidate (RC2) of Apache Drill,
>> version 1.17.0.
>>
>> Changes since the previous release candidate: fixed show-stopper DRILL-7494
>> <https://issues.apache.org/jira/browse/DRILL-7494>.
>>
>> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
>> everyone who contributed to this release.
>>
>> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
>> at [3].
>>
>> This release candidate is based on
>> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>>
>> Please download and try out the release.
>>
>> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
>> 2019
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Here's my vote: +1
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
>> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
>> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
>> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>>
>> Kind regards,
>> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Arina Yelchiyeva <ar...@gmail.com>.
Hi Paul,
thanks for verifying the release.
Regression for the release is considered something that worked in previous version, in our case in 1.16 and stopped working in the released, in our case case 1.17. Vova has checked both sqltypeof issues, they behave the same in 1.16 so from the release perspective, they are not regressions but bugs. Thus they won’t have sinked the last release candidate. By the way, one of the issues actually was a deliberate change in 1.16, I have left comment in Jira.
Regarding minor release, since both issues are not regressions, there is no point of doing it. Though if they were, I would still say we should not prepare minor release unless found bugs are something really serious that prevents Drill from starting. Mostly because release preparation takes time not only for the release manager but for the PMCs and committers to verify and cast votes.
Actually, it a good time to think when we want to release 1.18 and find volunteer to be a release manager.
Kind regards,
Arina
> On 27 Dec 2019, at 04:48, Paul Rogers <pa...@yahoo.com.invalid> wrote:
>
> Hi Charles,
>
> Good question! We have a number of big changes queued up. To do a minor release, we'd want to branch off of the Drill 1.17 release, which is extra work.
>
>
> Let's see if anyone finds other issues we'd like to fix so we can see if the effort would be worthwhile.
>
>
> Thanks,
> - Paul
>
>
>
> On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <cg...@gmail.com> wrote:
>
> Paul,
> Do you think it's worth fixing these and releasing a minor release in a month or so with this and any other minor bug fixes?
> -- C
>
>> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID> wrote:
>>
>> Hi All,
>>
>> I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
>>
>> It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
>>
>> These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
>>
>> Otherwise, everything seemed to work fine.
>>
>> Thanks,
>> - Paul
>>
>>
>>
>> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>>
>> Hi all,
>>
>> I'd like to propose the third release candidate (RC2) of Apache Drill,
>> version 1.17.0.
>>
>> Changes since the previous release candidate: fixed show-stopper DRILL-7494
>> <https://issues.apache.org/jira/browse/DRILL-7494>.
>>
>> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
>> everyone who contributed to this release.
>>
>> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
>> at [3].
>>
>> This release candidate is based on
>> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>>
>> Please download and try out the release.
>>
>> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
>> 2019
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Here's my vote: +1
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
>> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
>> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
>> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>>
>> Kind regards,
>> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Hi Charles,
Good question! We have a number of big changes queued up. To do a minor release, we'd want to branch off of the Drill 1.17 release, which is extra work.
Let's see if anyone finds other issues we'd like to fix so we can see if the effort would be worthwhile.
Thanks,
- Paul
On Thursday, December 26, 2019, 6:24:27 PM PST, Charles Givre <cg...@gmail.com> wrote:
Paul,
Do you think it's worth fixing these and releasing a minor release in a month or so with this and any other minor bug fixes?
-- C
> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID> wrote:
>
> Hi All,
>
> I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
>
> It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
>
> These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
>
> Otherwise, everything seemed to work fine.
>
> Thanks,
> - Paul
>
>
>
> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>
> Hi all,
>
> I'd like to propose the third release candidate (RC2) of Apache Drill,
> version 1.17.0.
>
> Changes since the previous release candidate: fixed show-stopper DRILL-7494
> <https://issues.apache.org/jira/browse/DRILL-7494>.
>
> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
> everyone who contributed to this release.
>
> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
> at [3].
>
> This release candidate is based on
> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>
> Please download and try out the release.
>
> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
> 2019
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Here's my vote: +1
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>
> Kind regards,
> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Charles Givre <cg...@gmail.com>.
Paul,
Do you think it's worth fixing these and releasing a minor release in a month or so with this and any other minor bug fixes?
-- C
> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID> wrote:
>
> Hi All,
>
> I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
>
> It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
>
> These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
>
> Otherwise, everything seemed to work fine.
>
> Thanks,
> - Paul
>
>
>
> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>
> Hi all,
>
> I'd like to propose the third release candidate (RC2) of Apache Drill,
> version 1.17.0.
>
> Changes since the previous release candidate: fixed show-stopper DRILL-7494
> <https://issues.apache.org/jira/browse/DRILL-7494>.
>
> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
> everyone who contributed to this release.
>
> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
> at [3].
>
> This release candidate is based on
> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>
> Please download and try out the release.
>
> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
> 2019
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Here's my vote: +1
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>
> Kind regards,
> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Charles Givre <cg...@gmail.com>.
Paul,
Do you think it's worth fixing these and releasing a minor release in a month or so with this and any other minor bug fixes?
-- C
> On Dec 26, 2019, at 9:17 PM, Paul Rogers <pa...@yahoo.com.INVALID> wrote:
>
> Hi All,
>
> I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
>
> It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
>
> These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
>
> Otherwise, everything seemed to work fine.
>
> Thanks,
> - Paul
>
>
>
> On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>
> Hi all,
>
> I'd like to propose the third release candidate (RC2) of Apache Drill,
> version 1.17.0.
>
> Changes since the previous release candidate: fixed show-stopper DRILL-7494
> <https://issues.apache.org/jira/browse/DRILL-7494>.
>
> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
> everyone who contributed to this release.
>
> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
> at [3].
>
> This release candidate is based on
> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>
> Please download and try out the release.
>
> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
> 2019
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Here's my vote: +1
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>
> Kind regards,
> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Hi All,
I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
Otherwise, everything seemed to work fine.
Thanks,
- Paul
On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
Hi all,
I'd like to propose the third release candidate (RC2) of Apache Drill,
version 1.17.0.
Changes since the previous release candidate: fixed show-stopper DRILL-7494
<https://issues.apache.org/jira/browse/DRILL-7494>.
The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
everyone who contributed to this release.
The tarball artifacts are hosted at [2] and the maven artifacts are hosted
at [3].
This release candidate is based on
commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
Please download and try out the release.
The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
2019
[ ] +1
[ ] +0
[ ] -1
Here's my vote: +1
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
[2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
[3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
[4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
Kind regards,
Volodymyr Vysotskyi
Fwd: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Voting ends now. Thanks everybody who voted!
I'll post the results soon.
Kind regards,
Volodymyr Vysotskyi
On Wed, Dec 25, 2019 at 4:47 PM <ko...@die-optimisten.net> wrote:
> + Installed from binary tar archive
> + RC files have been replaced with stabile versions
> + JDBC connect with custom authenticator
> + Basic queries (CSV, text manipulation, join, etc.)
> + Logged in to web UI, reviewed profiles & logs, submitted trivial queries
>
> LGTM
> +1 (non-binding)
>
> Thx & BR
> Holger
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Volodymyr Vysotskyi <vo...@apache.org>.
Voting ends now. Thanks everybody who voted!
I'll post the results soon.
Kind regards,
Volodymyr Vysotskyi
On Wed, Dec 25, 2019 at 4:47 PM <ko...@die-optimisten.net> wrote:
> + Installed from binary tar archive
> + RC files have been replaced with stabile versions
> + JDBC connect with custom authenticator
> + Basic queries (CSV, text manipulation, join, etc.)
> + Logged in to web UI, reviewed profiles & logs, submitted trivial queries
>
> LGTM
> +1 (non-binding)
>
> Thx & BR
> Holger
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by ko...@die-optimisten.net.
+ Installed from binary tar archive
+ RC files have been replaced with stabile versions
+ JDBC connect with custom authenticator
+ Basic queries (CSV, text manipulation, join, etc.)
+ Logged in to web UI, reviewed profiles & logs, submitted trivial queries
LGTM
+1 (non-binding)
Thx & BR
Holger
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Denys Ordynskiy <de...@gmail.com>.
Built from sources on Linux and Windows.
Run Drill in embedded mode on Windows.
Connected DrillExplorer to the Drill thru ODBC driver.
+1 (binding)
Best Regards,
Denys Ordynskiy
On Tue, Dec 24, 2019 at 4:39 PM Arina Yelchiyeva <ar...@gmail.com>
wrote:
> Verified checksums and signatures.
> Unpacked tar.gz and started in embedded mode on Windows (used Java 8, 11).
> Run simple queries.
> Did not perform any sophisticated checks, since it is already the third
> candidate.
>
> +1 (binding)
>
> Kind regards,
> Arina
>
> > On Dec 23, 2019, at 5:01 PM, Charles Givre <cg...@gmail.com> wrote:
> >
> > Hello all,
> > I found a minor bug in the Excel format plugin (
> https://issues.apache.org/jira/browse/DRILL-7495 <
> https://issues.apache.org/jira/browse/DRILL-7495>) where if the first
> column in the spreadsheet is a date, the reader will throw an exception.
> This can be worked around by setting allTextMode to true. However, in so
> doing I also found that the README.md file didn't list that option
> correctly, so I will update that. I queried other excel files without
> incident and this only seemed to occur when the date was the first column.
> >
> > I created a JIRA for this, however, I don't think it is a blocking
> issue. If we encounter other blockers for RC2, I'll fix it for RC3, if
> not, I'd say we go with it and I'll fix for version 1.18. Regardless, I
> will try to fix this in the next few days.
> >
> > Successfully queried shape files, pcap, with and w/o TCP sessionization.
> >
> > So +1 for me.
> > -- C
> >
> >
> >
> >> On Dec 22, 2019, at 12:00 PM, Volodymyr Vysotskyi <vo...@apache.org>
> wrote:
> >>
> >> Hi all,
> >>
> >> I'd like to propose the third release candidate (RC2) of Apache Drill,
> >> version 1.17.0.
> >>
> >> Changes since the previous release candidate: fixed show-stopper
> DRILL-7494
> >> <https://issues.apache.org/jira/browse/DRILL-7494>.
> >>
> >> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks
> to
> >> everyone who contributed to this release.
> >>
> >> The tarball artifacts are hosted at [2] and the maven artifacts are
> hosted
> >> at [3].
> >>
> >> This release candidate is based on
> >> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
> >>
> >> Please download and try out the release.
> >>
> >> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December
> 25,
> >> 2019
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Here's my vote: +1
> >>
> >> [1]
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> >> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> >> [3]
> https://repository.apache.org/content/repositories/orgapachedrill-1077/
> >> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
> >>
> >> Kind regards,
> >> Volodymyr Vysotskyi
> >
>
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Denys Ordynskiy <de...@gmail.com>.
Built from sources on Linux and Windows.
Run Drill in embedded mode on Windows.
Connected DrillExplorer to the Drill thru ODBC driver.
+1 (binding)
Best Regards,
Denys Ordynskiy
On Tue, Dec 24, 2019 at 4:39 PM Arina Yelchiyeva <ar...@gmail.com>
wrote:
> Verified checksums and signatures.
> Unpacked tar.gz and started in embedded mode on Windows (used Java 8, 11).
> Run simple queries.
> Did not perform any sophisticated checks, since it is already the third
> candidate.
>
> +1 (binding)
>
> Kind regards,
> Arina
>
> > On Dec 23, 2019, at 5:01 PM, Charles Givre <cg...@gmail.com> wrote:
> >
> > Hello all,
> > I found a minor bug in the Excel format plugin (
> https://issues.apache.org/jira/browse/DRILL-7495 <
> https://issues.apache.org/jira/browse/DRILL-7495>) where if the first
> column in the spreadsheet is a date, the reader will throw an exception.
> This can be worked around by setting allTextMode to true. However, in so
> doing I also found that the README.md file didn't list that option
> correctly, so I will update that. I queried other excel files without
> incident and this only seemed to occur when the date was the first column.
> >
> > I created a JIRA for this, however, I don't think it is a blocking
> issue. If we encounter other blockers for RC2, I'll fix it for RC3, if
> not, I'd say we go with it and I'll fix for version 1.18. Regardless, I
> will try to fix this in the next few days.
> >
> > Successfully queried shape files, pcap, with and w/o TCP sessionization.
> >
> > So +1 for me.
> > -- C
> >
> >
> >
> >> On Dec 22, 2019, at 12:00 PM, Volodymyr Vysotskyi <vo...@apache.org>
> wrote:
> >>
> >> Hi all,
> >>
> >> I'd like to propose the third release candidate (RC2) of Apache Drill,
> >> version 1.17.0.
> >>
> >> Changes since the previous release candidate: fixed show-stopper
> DRILL-7494
> >> <https://issues.apache.org/jira/browse/DRILL-7494>.
> >>
> >> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks
> to
> >> everyone who contributed to this release.
> >>
> >> The tarball artifacts are hosted at [2] and the maven artifacts are
> hosted
> >> at [3].
> >>
> >> This release candidate is based on
> >> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
> >>
> >> Please download and try out the release.
> >>
> >> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December
> 25,
> >> 2019
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Here's my vote: +1
> >>
> >> [1]
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> >> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> >> [3]
> https://repository.apache.org/content/repositories/orgapachedrill-1077/
> >> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
> >>
> >> Kind regards,
> >> Volodymyr Vysotskyi
> >
>
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Arina Yelchiyeva <ar...@gmail.com>.
Verified checksums and signatures.
Unpacked tar.gz and started in embedded mode on Windows (used Java 8, 11).
Run simple queries.
Did not perform any sophisticated checks, since it is already the third candidate.
+1 (binding)
Kind regards,
Arina
> On Dec 23, 2019, at 5:01 PM, Charles Givre <cg...@gmail.com> wrote:
>
> Hello all,
> I found a minor bug in the Excel format plugin (https://issues.apache.org/jira/browse/DRILL-7495 <https://issues.apache.org/jira/browse/DRILL-7495>) where if the first column in the spreadsheet is a date, the reader will throw an exception. This can be worked around by setting allTextMode to true. However, in so doing I also found that the README.md file didn't list that option correctly, so I will update that. I queried other excel files without incident and this only seemed to occur when the date was the first column.
>
> I created a JIRA for this, however, I don't think it is a blocking issue. If we encounter other blockers for RC2, I'll fix it for RC3, if not, I'd say we go with it and I'll fix for version 1.18. Regardless, I will try to fix this in the next few days.
>
> Successfully queried shape files, pcap, with and w/o TCP sessionization.
>
> So +1 for me.
> -- C
>
>
>
>> On Dec 22, 2019, at 12:00 PM, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>>
>> Hi all,
>>
>> I'd like to propose the third release candidate (RC2) of Apache Drill,
>> version 1.17.0.
>>
>> Changes since the previous release candidate: fixed show-stopper DRILL-7494
>> <https://issues.apache.org/jira/browse/DRILL-7494>.
>>
>> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
>> everyone who contributed to this release.
>>
>> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
>> at [3].
>>
>> This release candidate is based on
>> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>>
>> Please download and try out the release.
>>
>> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
>> 2019
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Here's my vote: +1
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
>> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
>> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
>> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>>
>> Kind regards,
>> Volodymyr Vysotskyi
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Arina Yelchiyeva <ar...@gmail.com>.
Verified checksums and signatures.
Unpacked tar.gz and started in embedded mode on Windows (used Java 8, 11).
Run simple queries.
Did not perform any sophisticated checks, since it is already the third candidate.
+1 (binding)
Kind regards,
Arina
> On Dec 23, 2019, at 5:01 PM, Charles Givre <cg...@gmail.com> wrote:
>
> Hello all,
> I found a minor bug in the Excel format plugin (https://issues.apache.org/jira/browse/DRILL-7495 <https://issues.apache.org/jira/browse/DRILL-7495>) where if the first column in the spreadsheet is a date, the reader will throw an exception. This can be worked around by setting allTextMode to true. However, in so doing I also found that the README.md file didn't list that option correctly, so I will update that. I queried other excel files without incident and this only seemed to occur when the date was the first column.
>
> I created a JIRA for this, however, I don't think it is a blocking issue. If we encounter other blockers for RC2, I'll fix it for RC3, if not, I'd say we go with it and I'll fix for version 1.18. Regardless, I will try to fix this in the next few days.
>
> Successfully queried shape files, pcap, with and w/o TCP sessionization.
>
> So +1 for me.
> -- C
>
>
>
>> On Dec 22, 2019, at 12:00 PM, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>>
>> Hi all,
>>
>> I'd like to propose the third release candidate (RC2) of Apache Drill,
>> version 1.17.0.
>>
>> Changes since the previous release candidate: fixed show-stopper DRILL-7494
>> <https://issues.apache.org/jira/browse/DRILL-7494>.
>>
>> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
>> everyone who contributed to this release.
>>
>> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
>> at [3].
>>
>> This release candidate is based on
>> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>>
>> Please download and try out the release.
>>
>> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
>> 2019
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Here's my vote: +1
>>
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
>> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
>> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
>> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>>
>> Kind regards,
>> Volodymyr Vysotskyi
>
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Charles Givre <cg...@gmail.com>.
Hello all,
I found a minor bug in the Excel format plugin (https://issues.apache.org/jira/browse/DRILL-7495 <https://issues.apache.org/jira/browse/DRILL-7495>) where if the first column in the spreadsheet is a date, the reader will throw an exception. This can be worked around by setting allTextMode to true. However, in so doing I also found that the README.md file didn't list that option correctly, so I will update that. I queried other excel files without incident and this only seemed to occur when the date was the first column.
I created a JIRA for this, however, I don't think it is a blocking issue. If we encounter other blockers for RC2, I'll fix it for RC3, if not, I'd say we go with it and I'll fix for version 1.18. Regardless, I will try to fix this in the next few days.
Successfully queried shape files, pcap, with and w/o TCP sessionization.
So +1 for me.
-- C
> On Dec 22, 2019, at 12:00 PM, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>
> Hi all,
>
> I'd like to propose the third release candidate (RC2) of Apache Drill,
> version 1.17.0.
>
> Changes since the previous release candidate: fixed show-stopper DRILL-7494
> <https://issues.apache.org/jira/browse/DRILL-7494>.
>
> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
> everyone who contributed to this release.
>
> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
> at [3].
>
> This release candidate is based on
> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>
> Please download and try out the release.
>
> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
> 2019
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Here's my vote: +1
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>
> Kind regards,
> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Charles Givre <cg...@gmail.com>.
Hello all,
I found a minor bug in the Excel format plugin (https://issues.apache.org/jira/browse/DRILL-7495 <https://issues.apache.org/jira/browse/DRILL-7495>) where if the first column in the spreadsheet is a date, the reader will throw an exception. This can be worked around by setting allTextMode to true. However, in so doing I also found that the README.md file didn't list that option correctly, so I will update that. I queried other excel files without incident and this only seemed to occur when the date was the first column.
I created a JIRA for this, however, I don't think it is a blocking issue. If we encounter other blockers for RC2, I'll fix it for RC3, if not, I'd say we go with it and I'll fix for version 1.18. Regardless, I will try to fix this in the next few days.
Successfully queried shape files, pcap, with and w/o TCP sessionization.
So +1 for me.
-- C
> On Dec 22, 2019, at 12:00 PM, Volodymyr Vysotskyi <vo...@apache.org> wrote:
>
> Hi all,
>
> I'd like to propose the third release candidate (RC2) of Apache Drill,
> version 1.17.0.
>
> Changes since the previous release candidate: fixed show-stopper DRILL-7494
> <https://issues.apache.org/jira/browse/DRILL-7494>.
>
> The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
> everyone who contributed to this release.
>
> The tarball artifacts are hosted at [2] and the maven artifacts are hosted
> at [3].
>
> This release candidate is based on
> commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
>
> Please download and try out the release.
>
> The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
> 2019
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Here's my vote: +1
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
> [2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
> [3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
> [4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
>
> Kind regards,
> Volodymyr Vysotskyi
Re: [VOTE] Release Apache Drill 1.17.0 - RC2
Posted by Paul Rogers <pa...@yahoo.com.INVALID>.
Hi All,
I'm late to the party (was distracted by a certain holiday). Downloaded the artifacts and ran though the examples in the first several sections of Chapter 8 of the Learning Apache Drill book.
It turns out we have a regression in the sqlTypeOf() function. See DRILL-7499 and DRILL-7501.
These are minor as they only affect users of the functions. But, the errors cause the results in Drill 1.17 to regress from those in Drill 1.14 (when the book was written.)
Otherwise, everything seemed to work fine.
Thanks,
- Paul
On Sunday, December 22, 2019, 9:00:52 AM PST, Volodymyr Vysotskyi <vo...@apache.org> wrote:
Hi all,
I'd like to propose the third release candidate (RC2) of Apache Drill,
version 1.17.0.
Changes since the previous release candidate: fixed show-stopper DRILL-7494
<https://issues.apache.org/jira/browse/DRILL-7494>.
The release candidate covers a total of 205 resolved JIRAs [1]. Thanks to
everyone who contributed to this release.
The tarball artifacts are hosted at [2] and the maven artifacts are hosted
at [3].
This release candidate is based on
commit 2eb6bbe0501cb6553106e63dc1f2810ff10ae375 located at [4].
Please download and try out the release.
The vote ends at 5 PM UTC (9 AM PDT, 7 PM EET, 10:30 PM IST), December 25,
2019
[ ] +1
[ ] +0
[ ] -1
Here's my vote: +1
[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344870
[2] http://home.apache.org/~volodymyr/drill/releases/1.17.0/rc2/
[3] https://repository.apache.org/content/repositories/orgapachedrill-1077/
[4] https://github.com/vvysotskyi/drill/commits/drill-1.17.0
Kind regards,
Volodymyr Vysotskyi