You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/04/25 09:49:26 UTC

[GitHub] [iceberg] chenjunjiedada opened a new pull request #2509: Core: fix NPE when reading manifest files as table

chenjunjiedada opened a new pull request #2509:
URL: https://github.com/apache/iceberg/pull/2509


   This is for https://github.com/apache/iceberg/issues/2405. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] chenjunjiedada closed pull request #2509: Core: fix NPE when reading manifest files as table

Posted by GitBox <gi...@apache.org>.
chenjunjiedada closed pull request #2509:
URL: https://github.com/apache/iceberg/pull/2509


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx commented on pull request #2509: Core: fix NPE when reading manifest files as table

Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #2509:
URL: https://github.com/apache/iceberg/pull/2509#issuecomment-826456799


   @chenjunjiedada ,  Is it possible to provide an unit tests to covert the case ?  I'd like to understand the internal reason that why do we need to fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] yyanyy commented on pull request #2509: Core: fix NPE when reading manifest files as table

Posted by GitBox <gi...@apache.org>.
yyanyy commented on pull request #2509:
URL: https://github.com/apache/iceberg/pull/2509#issuecomment-827222973


   I have raised a separate PR with a slightly different approach and some spec update in #2521, more context on why we need this change could be found in #2405. Thanks! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] yyanyy commented on pull request #2509: Core: fix NPE when reading manifest files as table

Posted by GitBox <gi...@apache.org>.
yyanyy commented on pull request #2509:
URL: https://github.com/apache/iceberg/pull/2509#issuecomment-829642791


   I guess we can close this one now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx commented on pull request #2509: Core: fix NPE when reading manifest files as table

Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #2509:
URL: https://github.com/apache/iceberg/pull/2509#issuecomment-826456799


   @chenjunjiedada ,  Is it possible to provide an unit tests to covert the case ?  I'd like to understand the internal reason that why do we need to fix this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org