[GitHub] hlgp commented on a change in pull request #453: Add retry mechanism to AccumuloReloadingVFSClassLoader.

[GitBox <gi...@apache.org>]

hlgp commented on a change in pull request #453: Add retry mechanism to AccumuloReloadingVFSClassLoader.  
URL: https://github.com/apache/accumulo/pull/453#discussion_r185272661
 
 

 ##########
 File path: start/src/main/java/org/apache/accumulo/start/classloader/vfs/AccumuloVFSClassLoader.java
 ##########
 @@ -152,14 +152,19 @@ public void run() {
         case IMAGINARY:
           // assume its a pattern
           String pattern = fo.getName().getBaseName();
-          if (fo.getParent() != null && fo.getParent().getType() == FileType.FOLDER) {
+          if (fo.getParent() != null) {
 
 Review comment:
   This change allows the parent directory to be monitored whether it exists yet or not on startup.  If a directory we have configured for monitoring is empty or nonexistent at startup, we never check for its existence again.  This allows us to still watch for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services